Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Issue 2742753002: Make SpellChecker::clearMisspellingsForMovingParagraphs() to take SelectionInDOMTree (Closed)
Patch Set: 2017-03-09T18:27:07 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
index 1bb7922fe8f2ec84519561467181a43c7e058540..d96c26dc7134258a9d284a9003c3f1713db1af96 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
@@ -319,9 +319,10 @@ void SpellChecker::showSpellingGuessPanel() {
}
void SpellChecker::clearMisspellingsForMovingParagraphs(
- const VisibleSelection& movingSelection) {
- removeMarkers(movingSelection.toNormalizedEphemeralRange(),
- DocumentMarker::MisspellingMarkers());
+ const SelectionInDOMTree& movingSelection) {
+ removeMarkers(
+ createVisibleSelection(movingSelection).toNormalizedEphemeralRange(),
Xiaocheng 2017/03/09 19:14:23 Is there any way to get rid of this canonicalizati
yosin_UTC9 2017/03/10 00:58:00 I guess we can use VS::start/end here. Or, we get
+ DocumentMarker::MisspellingMarkers());
}
void SpellChecker::markMisspellingsForMovingParagraphs(
« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698