Delete RenderPassSink

cc/layers/render_surface_impl.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/render_surface_impl.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 
@@ skipping 339 matching lines @@
 }
 
 void RenderSurfaceImpl::ClearLayerLists() {
   layer_list_.clear();
 }
 
 int RenderSurfaceImpl::GetRenderPassId() {
   return id();
 }
 
-void RenderSurfaceImpl::AppendRenderPasses(RenderPassSink* pass_sink) {
+void RenderSurfaceImpl::AppendRenderPass(RenderPassSink* pass_sink) {

[danakj, 2017/03/13 14:46:00]

Now that this is the case, this function doesn't use anything private to
RenderSurfaceImpl. We could delete this function (and the whole RenderPassSink
concept) and just do this based on the public members of RenderSurfaceImpl at
the callsite, if you like.

[danakj, 2017/03/13 14:47:51]

Or, if you like, this could just return a unique_ptr<RenderPass> to the caller
if you wanna keep this code here. But either way RenderPassSink can go away now.

   std::unique_ptr<RenderPass> pass = RenderPass::Create(layer_list_.size());
   gfx::Rect damage_rect = GetDamageRect();
   damage_rect.Intersect(content_rect());
   pass->SetNew(id(), content_rect(), damage_rect,
                draw_properties_.screen_space_transform);
   pass->filters = Filters();
   pass->background_filters = BackgroundFilters();
   pass_sink->AppendRenderPass(std::move(pass));
 }
 
@@ skipping 48 matching lines @@
   RenderPassDrawQuad* quad =
       render_pass->CreateAndAppendDrawQuad<RenderPassDrawQuad>();
   quad->SetNew(
       shared_quad_state, content_rect(), visible_layer_rect, GetRenderPassId(),
       mask_resource_id, gfx::ScaleRect(gfx::RectF(content_rect()),
                                        mask_uv_scale.x(), mask_uv_scale.y()),
       mask_texture_size, surface_contents_scale, FiltersOrigin(), gfx::RectF());
 }
 
 }  // namespace cc