[debugger] correctly annotate scripts with debug id.

[debugger] correctly annotate scripts with debug id.

Previously, we would incorrectly not assign any debug id to scripts
deserialized from the code cache.

R=jgruber@chromium.org
BUG=v8:6072
Review-Url: https://codereview.chromium.org/2742713003
Cr-Commit-Position: refs/heads/master@{#43740}
Committed: https://chromium.googlesource.com/v8/v8/+/07ee0b175cdf8048ad23b8f58ad24df3d8426b4b

[Yang, 2017-03-10 06:29:45]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 06:29:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 07:47:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 07:47:23]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-03-10 08:29:34]

lgtm

https://codereview.chromium.org/2742713003/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/2742713003/diff/1/src/compiler.cc#newcode1510
src/compiler.cc:1510: if (eval_result.has_shared()) {
Nit: Maybe we could merge this if block with the corresponding else at line 1519
to make this a bit more readable.

https://codereview.chromium.org/2742713003/diff/1/src/compiler.cc#newcode1690
src/compiler.cc:1690: // TODO(mvstanton): create a feedback vector array here.
Looks like maybe we can remove this TODO as well.

[Yang, 2017-03-13 08:46:27]

https://codereview.chromium.org/2742713003/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/2742713003/diff/1/src/compiler.cc#newcode1510
src/compiler.cc:1510: if (eval_result.has_shared()) {
On 2017/03/10 08:29:34, jgruber wrote:
> Nit: Maybe we could merge this if block with the corresponding else at line
1519
> to make this a bit more readable. 

Done.

https://codereview.chromium.org/2742713003/diff/1/src/compiler.cc#newcode1690
src/compiler.cc:1690: // TODO(mvstanton): create a feedback vector array here.
On 2017/03/10 08:29:34, jgruber wrote:
> Looks like maybe we can remove this TODO as well.

Done.

[Yang, 2017-03-13 08:46:30]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-03-13 08:46:30]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2742713003/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-03-13 08:46:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 09:13:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489394790441310,
"parent_rev": "78199ce5e0f3f6597284e0dae25164ccd8e63886", "commit_rev":
"07ee0b175cdf8048ad23b8f58ad24df3d8426b4b"}

[commit-bot: I haz the power, 2017-03-13 09:13:52]

Description was changed from

==========
[debugger] correctly annotate scripts with debug id.

Previously, we would incorrectly not assign any debug id to scripts
deserialized from the code cache.

R=jgruber@chromium.org
BUG=v8:6072
==========

to

==========
[debugger] correctly annotate scripts with debug id.

Previously, we would incorrectly not assign any debug id to scripts
deserialized from the code cache.

R=jgruber@chromium.org
BUG=v8:6072

Review-Url: https://codereview.chromium.org/2742713003
Cr-Commit-Position: refs/heads/master@{#43740}
Committed:
https://chromium.googlesource.com/v8/v8/+/07ee0b175cdf8048ad23b8f58ad24df3d84...
==========

[commit-bot: I haz the power, 2017-03-13 09:13:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/07ee0b175cdf8048ad23b8f58ad24df3d84...