Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Issue 2742693006: Add Data Saver ChromeDriver test for MissingViaHeader4xx bypass behavior (Closed)

Created:
3 years, 9 months ago by sclittle
Modified:
3 years, 9 months ago
Reviewers:
Robert Ogden, megjablon
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Data Saver ChromeDriver test for MissingViaHeader4xx bypass behavior This test attempts to load a page through a test proxy that doesn't set the via header properly on a 4xx-error response, and verifies that Chrome bypasses all proxies and retries the request over direct. BUG=700612 Review-Url: https://codereview.chromium.org/2742693006 Cr-Commit-Position: refs/heads/master@{#456809} Committed: https://chromium.googlesource.com/chromium/src/+/ee873e760f26ecebde137f160a2673ae83359bd3

Patch Set 1 #

Patch Set 2 : Rebased on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M tools/chrome_proxy/webdriver/bypass.py View 1 1 chunk +33 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
sclittle
3 years, 9 months ago (2017-03-11 02:32:27 UTC) #2
megjablon
lgtm
3 years, 9 months ago (2017-03-14 17:39:26 UTC) #3
Robert Ogden
lgtm
3 years, 9 months ago (2017-03-14 18:18:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742693006/20001
3 years, 9 months ago (2017-03-14 19:29:49 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 20:17:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ee873e760f26ecebde137f160a26...

Powered by Google App Engine
This is Rietveld 408576698