Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2742693004: Fix --dsym-hint passed to llvm analyzer

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Fix --dsym-hint passed to llvm analyzer Now that we have versioned frameworks, the location of the .dSYM file has changed. Pass the correct new location to fix symbols on the Mac/ASan bots. BUG=699153, 662466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/valgrind/asan/asan_symbolize.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (11 generated)
Nico
This is a complete guess and untested and whatnot, solely based on what you said ...
3 years, 9 months ago (2017-03-10 16:26:32 UTC) #3
Robert Sesek
lgtm
3 years, 9 months ago (2017-03-10 17:22:24 UTC) #10
Nico
3 years, 9 months ago (2017-03-10 18:05:36 UTC) #13
doesn't look like it helped:
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_asa...

guess i'll debug it a bit.

Powered by Google App Engine
This is Rietveld 408576698