Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: tools/valgrind/asan/asan_symbolize.py

Issue 2742693004: Fix --dsym-hint passed to llvm analyzer
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/asan/asan_symbolize.py
diff --git a/tools/valgrind/asan/asan_symbolize.py b/tools/valgrind/asan/asan_symbolize.py
index 2cdae08b18ab370fd81a0c427d3a323a6b33afac..6fa010f9237b98ae9a4fdebdd6aa5e8ebe9c7b1a 100755
--- a/tools/valgrind/asan/asan_symbolize.py
+++ b/tools/valgrind/asan/asan_symbolize.py
@@ -123,7 +123,7 @@ def make_chrome_osx_binary_name_filter(product_dir_path=''):
# 1. The binary is a standalone executable or dynamic library in the product
# dir, the debug info is in "binary.dSYM" in the product dir.
# 2. The binary is a standalone framework or .app bundle, the debug info is in
-# "Framework.framework.dSYM" or "App.app.dSYM" in the product dir.
+# "Framework.dSYM" or "App.dSYM" in the product dir.
# 3. The binary is a framework or an .app bundle within another .app bundle
# (e.g. Outer.app/Contents/Versions/1.2.3.4/Inner.app), and the debug info
# is in Inner.app.dSYM in the product dir.
@@ -159,7 +159,7 @@ def chrome_dsym_hints(binary):
# In case 2 this is the same as |outermost_bundle|.
innermost_bundle = bundle_positions[-1]
dsym_path = product_dir + [path_parts[innermost_bundle]]
- result = '%s.dSYM' % os.path.join(*dsym_path)
+ result = '%s.dSYM' % os.path.splitext(os.path.join(*dsym_path))[0]
return [result]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698