Disable auto-fullscreen for downloaded video

Disable auto-fullscreen for downloaded video

Disabling auto-fullscreen for downloaded media until the janky video
transitions are fixed.

BUG=698353
Review-Url: https://codereview.chromium.org/2742693003
Cr-Commit-Position: refs/heads/master@{#456156}
Committed: https://chromium.googlesource.com/chromium/src/+/c40ed1ae889b81d0f2fa1de05e2aa269257b5fd2

[shaktisahu, 2017-03-09 21:08:01]

Description was changed from

==========
Disable auto-fullscreen

Disabling auto-fullscreen for downloaded media until the janky video
transitions are fixed.

BUG=698353
==========

to

==========
Disable auto-fullscreen

Disabling auto-fullscreen for downloaded media until the janky video
transitions are fixed.

BUG=698353
==========

[shaktisahu, 2017-03-09 21:08:01]

shaktisahu@chromium.org changed reviewers:
+ dtrainor@chromium.org, mlamouri@chromium.org

[shaktisahu, 2017-03-09 21:10:35]

Description was changed from

==========
Disable auto-fullscreen

Disabling auto-fullscreen for downloaded media until the janky video
transitions are fixed.

BUG=698353
==========

to

==========
Disable auto-fullscreen for downloaded video

Disabling auto-fullscreen for downloaded media until the janky video
transitions are fixed.

BUG=698353
==========

[shaktisahu, 2017-03-09 21:11:28]

PTAL

[mlamouri (slow - plz ping), 2017-03-10 15:46:51]

lgtm

https://codereview.chromium.org/2742693003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/MediaDocument.cpp (right):

https://codereview.chromium.org/2742693003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/MediaDocument.cpp:140: //
media->webkitEnterFullscreen();
No need to leave the code commented, the TODO should be enough.
nit: I would add https:// in front of crbug to make it clickable for anyone who
has their editor set up for this.

[David Trainor- moved to gerrit, 2017-03-10 19:23:56]

lgtm % mlamouri@'s comment

[shaktisahu, 2017-03-10 19:33:08]

The CQ bit was checked by shaktisahu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 19:33:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 20:49:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 20:49:21]

Dry run: This issue passed the CQ dry run.

[shaktisahu, 2017-03-10 20:49:47]

The CQ bit was checked by shaktisahu@chromium.org

[shaktisahu, 2017-03-10 20:49:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2742693003/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2017-03-10 20:50:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 20:57:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489178987040180,
"parent_rev": "4a3253c3dc5edc041db7f64cca32476181f09013", "commit_rev":
"c40ed1ae889b81d0f2fa1de05e2aa269257b5fd2"}

[commit-bot: I haz the power, 2017-03-10 20:58:09]

Description was changed from

==========
Disable auto-fullscreen for downloaded video

Disabling auto-fullscreen for downloaded media until the janky video
transitions are fixed.

BUG=698353
==========

to

==========
Disable auto-fullscreen for downloaded video

Disabling auto-fullscreen for downloaded media until the janky video
transitions are fixed.

BUG=698353

Review-Url: https://codereview.chromium.org/2742693003
Cr-Commit-Position: refs/heads/master@{#456156}
Committed:
https://chromium.googlesource.com/chromium/src/+/c40ed1ae889b81d0f2fa1de05e2a...
==========

[commit-bot: I haz the power, 2017-03-10 20:58:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c40ed1ae889b81d0f2fa1de05e2a...