Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2742653002: Fix custom formatter setup (Closed)

Created:
3 years, 9 months ago by vsm
Modified:
3 years, 9 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pkg/dev_compiler/lib/js/legacy/dart_library.js View 2 chunks +4 lines, -4 lines 3 comments Download

Messages

Total messages: 6 (2 generated)
vsm
https://codereview.chromium.org/2742653002/diff/1/pkg/dev_compiler/lib/js/legacy/dart_library.js File pkg/dev_compiler/lib/js/legacy/dart_library.js (left): https://codereview.chromium.org/2742653002/diff/1/pkg/dev_compiler/lib/js/legacy/dart_library.js#oldcode189 pkg/dev_compiler/lib/js/legacy/dart_library.js:189: dart_sdk._debugger.registerDevtoolsFormatter(); dart_sdk isn't defined here - breaking internal tests
3 years, 9 months ago (2017-03-09 02:54:07 UTC) #2
Jacob
lgtm
3 years, 9 months ago (2017-03-09 02:55:50 UTC) #3
vsm
Committed patchset #1 (id:1) manually as 089d9c4afa1d4f52a82ac12a8f37d87ac6d791f8 (presubmit successful).
3 years, 9 months ago (2017-03-09 02:58:15 UTC) #5
Jacob
3 years, 9 months ago (2017-03-09 02:59:07 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2742653002/diff/1/pkg/dev_compiler/lib/js/leg...
File pkg/dev_compiler/lib/js/legacy/dart_library.js (left):

https://codereview.chromium.org/2742653002/diff/1/pkg/dev_compiler/lib/js/leg...
pkg/dev_compiler/lib/js/legacy/dart_library.js:182: let _bootstrapped = false;
with this tweak the bootstrap method is now a no op. remove?

https://codereview.chromium.org/2742653002/diff/1/pkg/dev_compiler/lib/js/leg...
File pkg/dev_compiler/lib/js/legacy/dart_library.js (right):

https://codereview.chromium.org/2742653002/diff/1/pkg/dev_compiler/lib/js/leg...
pkg/dev_compiler/lib/js/legacy/dart_library.js:173: // option to compile without
it.
you should make sure registerDevtoolsFormatter isn't called multiple times.

Powered by Google App Engine
This is Rietveld 408576698