Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: pkg/dev_compiler/lib/js/legacy/dart_library.js

Issue 2742653002: Fix custom formatter setup (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/js/legacy/dart_library.js
diff --git a/pkg/dev_compiler/lib/js/legacy/dart_library.js b/pkg/dev_compiler/lib/js/legacy/dart_library.js
index bb6ab0298b4104863721541114dbef67b0b89a07..4901310d7dc19511a577280266e389a8e4c13afd 100644
--- a/pkg/dev_compiler/lib/js/legacy/dart_library.js
+++ b/pkg/dev_compiler/lib/js/legacy/dart_library.js
@@ -169,6 +169,10 @@ dart_library =
let library = import_(moduleName)[libraryName];
let dart_sdk = import_('dart_sdk');
+ // This import is only needed for chrome debugging. We should provide an
+ // option to compile without it.
Jacob 2017/03/09 02:59:07 you should make sure registerDevtoolsFormatter isn
+ dart_sdk._debugger.registerDevtoolsFormatter();
+
if (!_currentIsolate) {
// Create isolate.
_currentIsolate = true;
@@ -183,10 +187,6 @@ dart_library =
function bootstrap() {
if (_bootstrapped) return;
_bootstrapped = true;
-
- // This import is only needed for chrome debugging. We should provide an
- // option to compile without it.
- dart_sdk._debugger.registerDevtoolsFormatter();
vsm 2017/03/09 02:54:07 dart_sdk isn't defined here - breaking internal te
}
})(dart_library);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698