Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2742643002: arc: Change VLOG to LOG for ArcAuthContext and fetcher. (Closed)

Created:
3 years, 9 months ago by khmel
Modified:
3 years, 9 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, oshima+watch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, khmel+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Change VLOG to LOG for ArcAuthContext and fetcher. This change VLOG(2) to LOG(WARNING) for failure reasons in ARC HTTP context preparation and background auth code fetcher. This information was missing in some user feedbacks responsible for SERVER_COMMUNICATION_ERROR failure. TEST=Ensure that log entries appear in Chrome Log BUG=700048 Review-Url: https://codereview.chromium.org/2742643002 Cr-Commit-Position: refs/heads/master@{#455815} Committed: https://chromium.googlesource.com/chromium/src/+/f2d4ff52c748b24a2a57a6f3d3fe7573744442ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_context.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
khmel
Hi Yusuke, PTAL, Thanks!
3 years, 9 months ago (2017-03-09 02:32:09 UTC) #2
Luis Héctor Chávez
lgtm
3 years, 9 months ago (2017-03-09 02:47:28 UTC) #6
Luis Héctor Chávez
ah just a nit: make sure the BUG= stanza points to a valid crbug.com bug.
3 years, 9 months ago (2017-03-09 02:48:28 UTC) #7
Yusuke Sato
lgtm
3 years, 9 months ago (2017-03-09 07:39:49 UTC) #10
khmel
Thank you for quick review in so busy time!
3 years, 9 months ago (2017-03-09 17:36:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742643002/1
3 years, 9 months ago (2017-03-09 17:36:34 UTC) #14
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 9 months ago (2017-03-09 18:07:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742643002/1
3 years, 9 months ago (2017-03-09 18:47:34 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 18:54:28 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f2d4ff52c748b24a2a57a6f3d3fe...

Powered by Google App Engine
This is Rietveld 408576698