|
|
Created:
3 years, 9 months ago by khmel Modified:
3 years, 9 months ago CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, oshima+watch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, khmel+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, davemoore+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionarc: Change VLOG to LOG for ArcAuthContext and fetcher.
This change VLOG(2) to LOG(WARNING) for failure reasons in ARC
HTTP context preparation and background auth code fetcher. This
information was missing in some user feedbacks responsible for
SERVER_COMMUNICATION_ERROR failure.
TEST=Ensure that log entries appear in Chrome Log
BUG=700048
Review-Url: https://codereview.chromium.org/2742643002
Cr-Commit-Position: refs/heads/master@{#455815}
Committed: https://chromium.googlesource.com/chromium/src/+/f2d4ff52c748b24a2a57a6f3d3fe7573744442ba
Patch Set 1 #
Messages
Total messages: 22 (13 generated)
khmel@chromium.org changed reviewers: + yusukes@chromium.org
Hi Yusuke, PTAL, Thanks!
The CQ bit was checked by khmel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lhchavez@chromium.org changed reviewers: + lhchavez@chromium.org
lgtm
ah just a nit: make sure the BUG= stanza points to a valid crbug.com bug.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
Description was changed from ========== arc: Change VLOG to LOG for ArcAuthContext and fetcher. This change VLOG(2) to LOG(WARNING) for failure reasons in ARC HTTP context preparation and background auth code fetcher. This information was missing in some user feedbacks responsible for SERVER_COMMUNICATION_ERROR failure. TEST=Ensure that log entries appear in Chrome Log BUG=36076099 ========== to ========== arc: Change VLOG to LOG for ArcAuthContext and fetcher. This change VLOG(2) to LOG(WARNING) for failure reasons in ARC HTTP context preparation and background auth code fetcher. This information was missing in some user feedbacks responsible for SERVER_COMMUNICATION_ERROR failure. TEST=Ensure that log entries appear in Chrome Log BUG=700048 ==========
Thank you for quick review in so busy time!
The CQ bit was checked by khmel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1489080973055360, "parent_rev": "f197528d286b7ecb15e1d0f8d6f05609d8c4b6a4", "commit_rev": "ab44ee94b53cc6006698a896d51b70a359c1178b"}
The CQ bit was unchecked by commit-bot@chromium.org
Prior attempt to commit was detected, but we were not able to check whether the issue was successfully committed. Please check Git history manually and re-check CQ or close this issue as needed.
The CQ bit was checked by khmel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1489085202542090, "parent_rev": "208cc84708940c682993ea5feff1003410e329b5", "commit_rev": "f2d4ff52c748b24a2a57a6f3d3fe7573744442ba"}
Message was sent while issue was closed.
Description was changed from ========== arc: Change VLOG to LOG for ArcAuthContext and fetcher. This change VLOG(2) to LOG(WARNING) for failure reasons in ARC HTTP context preparation and background auth code fetcher. This information was missing in some user feedbacks responsible for SERVER_COMMUNICATION_ERROR failure. TEST=Ensure that log entries appear in Chrome Log BUG=700048 ========== to ========== arc: Change VLOG to LOG for ArcAuthContext and fetcher. This change VLOG(2) to LOG(WARNING) for failure reasons in ARC HTTP context preparation and background auth code fetcher. This information was missing in some user feedbacks responsible for SERVER_COMMUNICATION_ERROR failure. TEST=Ensure that log entries appear in Chrome Log BUG=700048 Review-Url: https://codereview.chromium.org/2742643002 Cr-Commit-Position: refs/heads/master@{#455815} Committed: https://chromium.googlesource.com/chromium/src/+/f2d4ff52c748b24a2a57a6f3d3fe... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f2d4ff52c748b24a2a57a6f3d3fe... |