Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/get_landmines.py

Issue 2742603002: Fix VS 2015 Update 3, 14393 SDK landmine (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/get_landmines.py
diff --git a/build/get_landmines.py b/build/get_landmines.py
index c8d501bc218242bf54b70dbe28c4414615c30ba1..0216b1c64537424eae76f849588eb7f123917e9a 100755
--- a/build/get_landmines.py
+++ b/build/get_landmines.py
@@ -44,7 +44,7 @@ def print_landmines():
if platform() in ('win', 'mac'):
print ('Improper dependency for create_nmf.py broke in r240802, '
'fixed in r240860.')
- if (platform() == 'win' and gyp_msvs_version().startswith('2015')):
+ if platform() == 'win':
print 'Switch to VS2015 Update 3, 14393 SDK'
print 'Need to clobber everything due to an IDL change in r154579 (blink)'
print 'Need to clobber everything due to gen file moves in r175513 (Blink)'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698