Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2742593002: Add GLImageDXGI (Closed)

Created:
3 years, 9 months ago by jbauman
Modified:
3 years, 9 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GLImageDXGI This is used as the output from the DXVA video decoder. The DirectComposition swapchain will be able to use it to grab the texture to put into an overlay. BUG=678800 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2742593002 Cr-Commit-Position: refs/heads/master@{#456621} Committed: https://chromium.googlesource.com/chromium/src/+/200b59a1909d1bf32eac6a4c35d3a5b49cc4e01b

Patch Set 1 #

Patch Set 2 : add export #

Patch Set 3 : centralize cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -20 lines) Patch
M media/gpu/dxva_picture_buffer_win.cc View 1 2 6 chunks +13 lines, -16 lines 0 comments Download
M ui/gl/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_image.h View 1 chunk +1 line, -4 lines 0 comments Download
A ui/gl/gl_image_dxgi.h View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A ui/gl/gl_image_dxgi.cc View 1 2 1 chunk +79 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (17 generated)
jbauman
3 years, 9 months ago (2017-03-10 23:32:27 UTC) #12
sandersd (OOO until July 31)
lgtm; would prefer if there was a way to avoid the casts.
3 years, 9 months ago (2017-03-13 19:57:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742593002/40001
3 years, 9 months ago (2017-03-14 00:13:51 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/228040) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 9 months ago (2017-03-14 00:28:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742593002/40001
3 years, 9 months ago (2017-03-14 01:34:29 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 04:09:26 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/200b59a1909d1bf32eac6a4c35d3...

Powered by Google App Engine
This is Rietveld 408576698