Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2742583004: Android settings: conditionally show notification vibrate option (Closed)

Created:
3 years, 9 months ago by awdf
Modified:
3 years, 9 months ago
Reviewers:
Peter Beverloo, Finnur
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android settings: conditionally show notification vibrate option BUG=699537 Review-Url: https://codereview.chromium.org/2742583004 Cr-Commit-Position: refs/heads/master@{#455729} Committed: https://chromium.googlesource.com/chromium/src/+/1e55e49510812c8041307c7d1eef2282f80c0169

Patch Set 1 #

Patch Set 2 : add nullcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Peter Beverloo
lgtm
3 years, 9 months ago (2017-03-09 12:00:34 UTC) #4
awdf
+finnur for OWNERS Review
3 years, 9 months ago (2017-03-09 12:13:25 UTC) #7
Finnur
OWNERS LGTM
3 years, 9 months ago (2017-03-09 12:16:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742583004/20001
3 years, 9 months ago (2017-03-09 12:49:16 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 13:22:30 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1e55e49510812c8041307c7d1eef...

Powered by Google App Engine
This is Rietveld 408576698