Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2742583002: Make TopDocumentRootScrollerController store a non-weak Member<Page> (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, chromium-reviews, kenneth.christiansen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TopDocumentRootScrollerController store a non-weak Member<Page> Make TopDocumentRootScrollerController store a Member<Page> instead of a WeakMember<Page>. TopDocumentRootScrollerController and Page should live and die at the same time, so this can just be a Member<Page>. BUG=NONE Review-Url: https://codereview.chromium.org/2742583002 Cr-Commit-Position: refs/heads/master@{#456010} Committed: https://chromium.googlesource.com/chromium/src/+/04b3fc7475401166b44c14b201fb957a66436f1d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review Feedback #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (13 generated)
sashab
3 years, 9 months ago (2017-03-09 01:43:50 UTC) #6
haraken
LGTM https://codereview.chromium.org/2742583002/diff/1/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h File third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h (right): https://codereview.chromium.org/2742583002/diff/1/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h#newcode110 third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h:110: // time. We normally don't add a comment ...
3 years, 9 months ago (2017-03-09 06:30:35 UTC) #7
sashab
Removed the comment; thanks
3 years, 9 months ago (2017-03-10 02:19:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742583002/40001
3 years, 9 months ago (2017-03-10 05:01:46 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 06:39:12 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/04b3fc7475401166b44c14b201fb...

Powered by Google App Engine
This is Rietveld 408576698