DevTools: initial console suggestion should be greyed out

DevTools: initial console suggestion should be greyed out

This patch makes initial console suggestion greyed out until
user explicitly interactes with the suggest box.

BUG=700570
R=dgozman, pfeldman, einbinder

Review-Url: https://codereview.chromium.org/2742573007
Cr-Commit-Position: refs/heads/master@{#456283}
Committed: https://chromium.googlesource.com/chromium/src/+/a54a48cb6f59fe24dd4a4e566d42c9f059e9e242

[lushnikov, 2017-03-10 23:32:27]

please, take a look

[lushnikov, 2017-03-10 23:32:31]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 23:32:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-03-11 00:00:25]

https://codereview.chromium.org/2742573007/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
(right):

https://codereview.chromium.org/2742573007/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js:255:
this._suggestBox.setUserInteractionStyling(!!this._config.captureEnter);
setDefaultSelectionIsDimmed

https://codereview.chromium.org/2742573007/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js (right):

https://codereview.chromium.org/2742573007/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js:85:
this._userInteractionStyling = value;
Drop it.

https://codereview.chromium.org/2742573007/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/suggestBox.css (right):

https://codereview.chromium.org/2742573007/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/suggestBox.css:89:
--blurred-selected-background: rgb(56, 121, 217);
Let's do classic way for now.

[lushnikov, 2017-03-11 00:09:59]

all done; please take another look

https://codereview.chromium.org/2742573007/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js
(right):

https://codereview.chromium.org/2742573007/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/text_editor/TextEditorAutocompleteController.js:255:
this._suggestBox.setUserInteractionStyling(!!this._config.captureEnter);
On 2017/03/11 00:00:24, dgozman wrote:
> setDefaultSelectionIsDimmed

Done.

https://codereview.chromium.org/2742573007/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js (right):

https://codereview.chromium.org/2742573007/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js:85:
this._userInteractionStyling = value;
On 2017/03/11 00:00:24, dgozman wrote:
> Drop it.

Done.

https://codereview.chromium.org/2742573007/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/suggestBox.css (right):

https://codereview.chromium.org/2742573007/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/suggestBox.css:89:
--blurred-selected-background: rgb(56, 121, 217);
On 2017/03/11 00:00:24, dgozman wrote:
> Let's do classic way for now.

Done.

[lushnikov, 2017-03-11 00:10:35]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 00:11:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-03-11 00:24:36]

lgtm

[lushnikov, 2017-03-11 02:21:54]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-03-11 02:21:56]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-03-11 02:22:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 17:50:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489198916398840,
"parent_rev": "72df4334a57fdd13b8dbbc7cd48895fcd79b3a63", "commit_rev":
"a54a48cb6f59fe24dd4a4e566d42c9f059e9e242"}

[commit-bot: I haz the power, 2017-03-11 17:51:39]

Description was changed from

==========
DevTools: initial console suggestion should be greyed out

This patch makes initial console suggestion greyed out until
user explicitly interactes with the suggest box.

BUG=700570
R=dgozman, pfeldman, einbinder
==========

to

==========
DevTools: initial console suggestion should be greyed out

This patch makes initial console suggestion greyed out until
user explicitly interactes with the suggest box.

BUG=700570
R=dgozman, pfeldman, einbinder

Review-Url: https://codereview.chromium.org/2742573007
Cr-Commit-Position: refs/heads/master@{#456283}
Committed:
https://chromium.googlesource.com/chromium/src/+/a54a48cb6f59fe24dd4a4e566d42...
==========

[commit-bot: I haz the power, 2017-03-11 17:51:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a54a48cb6f59fe24dd4a4e566d42...