Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2742573006: Fix incognito progressbar color on tablet (Closed)

Created:
3 years, 9 months ago by mdjones
Modified:
3 years, 9 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incognito progressbar color on tablet Dynamic inflation of the progress bar caused it's color to be incorrect on incognito tabs. This change modifies the ToolbarTablet to set the appropriate color whenever the tab's model changes. BUG=698715 Review-Url: https://codereview.chromium.org/2742573006 Cr-Commit-Position: refs/heads/master@{#456201} Committed: https://chromium.googlesource.com/chromium/src/+/985672135b21e4512693ab3bbf0a9bdd5b362583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mdjones
ptal
3 years, 9 months ago (2017-03-10 21:46:45 UTC) #2
gone
lgtm
3 years, 9 months ago (2017-03-10 22:11:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742573006/1
3 years, 9 months ago (2017-03-10 22:14:58 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 22:50:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/985672135b21e4512693ab3bbf0a...

Powered by Google App Engine
This is Rietveld 408576698