Avoid to include IDL-generated headers from EventTarget.h and Node.h

Avoid to include IDL-generated headers from EventTarget.h and Node.h

Headers generated by IDL compiler bring a lot of binding headers. We should avoid
to include such headers in popular base classes such as EventTarget and Node.

Review-Url: https://codereview.chromium.org/2742573005
Cr-Commit-Position: refs/heads/master@{#456018}
Committed: https://chromium.googlesource.com/chromium/src/+/e074c7023701f08692d087cf3f74d77f6ee54a90

[tkent, 2017-03-10 04:39:27]

Description was changed from

==========
Avoid to include bindings/core/v8/V8Binding.h from Node.h.

BUG=
==========

to

==========
Avoid to include bindings/core/v8/V8Binding.h from Node.h.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[tkent, 2017-03-10 04:39:43]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 04:39:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 04:49:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 04:49:20]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2017-03-10 06:10:59]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 06:11:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-03-10 06:29:52]

Description was changed from

==========
Avoid to include bindings/core/v8/V8Binding.h from Node.h.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Avoid to include bindings/core/v8/V8Binding.h from EventTarget.h, Node.h, and
Document.h
==========

[tkent, 2017-03-10 06:30:11]

Description was changed from

==========
Avoid to include bindings/core/v8/V8Binding.h from EventTarget.h, Node.h, and
Document.h
==========

to

==========
Avoid to include bindings/core/v8/V8Binding.h from EventTarget.h and Node.h
==========

[tkent, 2017-03-10 06:49:26]

Description was changed from

==========
Avoid to include bindings/core/v8/V8Binding.h from EventTarget.h and Node.h
==========

to

==========
Avoid to include IDL-generated headers from EventTarget.h and Node.h

Headers generated by IDL compiler bring a lot of binding headers. We should
avoid
to include such headers in popular base classes such as EventTarget and Node.
==========

[tkent, 2017-03-10 07:09:16]

Patchset #1 (id:1) has been deleted

[tkent, 2017-03-10 07:10:00]

tkent@chromium.org changed reviewers:
+ bashi@chromium.org

[tkent, 2017-03-10 07:10:01]

bashi@, would you review this please?

[Yuki, 2017-03-10 07:28:52]

yukishiino@chromium.org changed reviewers:
+ yukishiino@chromium.org

[Yuki, 2017-03-10 07:28:53]

LGTM.

[bashi, 2017-03-10 07:29:11]

lgtm

[commit-bot: I haz the power, 2017-03-10 07:35:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 07:35:08]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-03-10 07:39:41]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-03-10 07:39:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 07:44:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489131581316000,
"parent_rev": "caf3c3acbe69ac013e2aaafad5c8110bb66e435a", "commit_rev":
"e074c7023701f08692d087cf3f74d77f6ee54a90"}

[commit-bot: I haz the power, 2017-03-10 07:45:36]

Description was changed from

==========
Avoid to include IDL-generated headers from EventTarget.h and Node.h

Headers generated by IDL compiler bring a lot of binding headers. We should
avoid
to include such headers in popular base classes such as EventTarget and Node.
==========

to

==========
Avoid to include IDL-generated headers from EventTarget.h and Node.h

Headers generated by IDL compiler bring a lot of binding headers. We should
avoid
to include such headers in popular base classes such as EventTarget and Node.

Review-Url: https://codereview.chromium.org/2742573005
Cr-Commit-Position: refs/heads/master@{#456018}
Committed:
https://chromium.googlesource.com/chromium/src/+/e074c7023701f08692d087cf3f74...
==========

[commit-bot: I haz the power, 2017-03-10 07:45:38]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e074c7023701f08692d087cf3f74...

[haraken, 2017-03-10 08:31:36]

LGTM

[Daniel Bratell, 2017-03-10 09:00:43]

Nice!

Checked the preprocessed VideoTrack.cpp file and this change shrunk it from
182198 lines to 177719 lines (-4479 lines).

Over a couple of thousand files, this will probably mean millions of fewer lines
of code through the compiler.