Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2742563003: customtabs: Respect delayToLaunchUrl even without delayToMayLaunchUrl. (Closed)

Created:
3 years, 9 months ago by trevordixon
Modified:
3 years, 9 months ago
Reviewers:
Benoit L
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Respect delayToLaunchUrl even without delayToMayLaunchUrl. In the Custom Tabs benchmark, in the case where mayLaunchUrl isn't called, launchUrl shouldn't be called immediately. This change causes launchUrl to be called after the delay specified by delayToLaunchUrl. BUG=655980 Review-Url: https://codereview.chromium.org/2742563003 Cr-Commit-Position: refs/heads/master@{#456038} Committed: https://chromium.googlesource.com/chromium/src/+/afc56429f8182efa5b97cda6ba8bed9999469a46

Patch Set 1 #

Patch Set 2 : Respect delayToLaunchUrl even without delayToMayLaunchUrl. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/android/customtabs_benchmark/java/src/org/chromium/customtabs/test/MainActivity.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
trevordixon
3 years, 9 months ago (2017-03-09 10:46:51 UTC) #2
Benoit L
On 2017/03/09 10:46:51, trevordixon wrote: lgtm, thanks. Note that you may have to rebase locally ...
3 years, 9 months ago (2017-03-09 17:10:19 UTC) #3
Benoit L
On 2017/03/09 10:46:51, trevordixon wrote: lgtm, thanks. Note that you may have to rebase locally ...
3 years, 9 months ago (2017-03-09 17:10:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742563003/20001
3 years, 9 months ago (2017-03-10 10:38:03 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 11:01:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/afc56429f8182efa5b97cda6ba8b...

Powered by Google App Engine
This is Rietveld 408576698