Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2742523005: Revert Change ServiceManagerConnectionImpl to run service request handlers on the IO thread (Closed)

Created:
3 years, 9 months ago by jonross
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert Change ServiceManagerConnectionImpl to run service request handlers on the IO thread Revert: https://codereview.chromium.org/2729733003/ As this is currently crashing on all mash builds, preventing development. TBR=rockot@chromium.org, jochen@chromium.org, sammc@chromium.org BUG=700155, 654988 Review-Url: https://codereview.chromium.org/2742523005 Cr-Commit-Position: refs/heads/master@{#456140} Committed: https://chromium.googlesource.com/chromium/src/+/3c309fdbb3787d140f76c1cfc3ef8a994d8d4a4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -130 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/browser_context.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/service_manager/service_manager_context.cc View 4 chunks +32 lines, -17 lines 0 comments Download
M content/common/service_manager/service_manager_connection_impl.h View 4 chunks +8 lines, -3 lines 0 comments Download
M content/common/service_manager/service_manager_connection_impl.cc View 12 chunks +33 lines, -49 lines 0 comments Download
D content/common/service_manager/service_manager_connection_impl_unittest.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742523005/1
3 years, 9 months ago (2017-03-10 18:42:40 UTC) #2
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 19:58:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3c309fdbb3787d140f76c1cfc3ef...

Powered by Google App Engine
This is Rietveld 408576698