Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2742523004: MD Settings: remove unnecessary secondary descriptions. (Closed)

Created:
3 years, 9 months ago by scottchen
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam, hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: remove unnecessary secondary descriptions. BUG=681223 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2742523004 Cr-Commit-Position: refs/heads/master@{#455974} Committed: https://chromium.googlesource.com/chromium/src/+/10184858622f92e96aa3aa550b72dab2dc2d2eef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -30 lines) Patch
M chrome/app/settings_strings.grdp View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cloud_printers.html View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.html View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
scottchen
3 years, 9 months ago (2017-03-10 00:35:22 UTC) #3
hcarmona
LGTM
3 years, 9 months ago (2017-03-10 00:38:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742523004/1
3 years, 9 months ago (2017-03-10 00:42:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/382481)
3 years, 9 months ago (2017-03-10 00:49:56 UTC) #8
Dan Beam
lgtm
3 years, 9 months ago (2017-03-10 02:55:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742523004/1
3 years, 9 months ago (2017-03-10 02:57:20 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 03:08:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/10184858622f92e96aa3aa550b72...

Powered by Google App Engine
This is Rietveld 408576698