Change ui/base/l10n/formatter LazyInstance to Leaky

Change ui/base/l10n/formatter LazyInstance to Leaky

I don't believe destroying the FormatterContainer, or its contained
Formatter, or their contained icu::MessageFormat is important either at
process shutdown, or in between tests.

TEST=ui_base_unittests --gtest_repeat=100 --gtest_shuffle
R=jshin@chromium.org
BUG=698982
Review-Url: https://codereview.chromium.org/2742463002
Cr-Commit-Position: refs/heads/master@{#455561}
Committed: https://chromium.googlesource.com/chromium/src/+/eae0bca61d34738c1386c4d34ea4a3588b4dc8df

[scottmg, 2017-03-08 20:26:13]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 20:26:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2017-03-08 20:46:07]

Description was changed from

==========
Change ui/base/l10n LazyInstance to Leaky

I don't see any important work being done in the destructor of these
objects, so I think they can be leaky.

TEST=ui_base_unittests --gtest_repeat=100 --gtest_shuffle
R=jshin@chromium.org
BUG=698982
==========

to

==========
Change ui/base/l10n/formatter LazyInstance to Leaky

I don't believe destroying the FormatterContainer, or its contained Formatter,
or their contained icu::MessageFormat is important either at process shutdown,
or in between tests.

TEST=ui_base_unittests --gtest_repeat=100 --gtest_shuffle
R=jshin@chromium.org
BUG=698982
==========

[scottmg, 2017-03-08 20:46:15]

Description was changed from

==========
Change ui/base/l10n/formatter LazyInstance to Leaky

I don't believe destroying the FormatterContainer, or its contained Formatter,
or their contained icu::MessageFormat is important either at process shutdown,
or in between tests.

TEST=ui_base_unittests --gtest_repeat=100 --gtest_shuffle
R=jshin@chromium.org
BUG=698982
==========

to

==========
Change ui/base/l10n/formatter LazyInstance to Leaky

I don't believe destroying the FormatterContainer, or its contained
Formatter, or their contained icu::MessageFormat is important either at
process shutdown, or in between tests.

TEST=ui_base_unittests --gtest_repeat=100 --gtest_shuffle
R=jshin@chromium.org
BUG=698982
==========

[scottmg, 2017-03-08 20:46:32]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 20:47:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jungshik at Google, 2017-03-08 22:00:18]

LGTM

[commit-bot: I haz the power, 2017-03-08 22:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 22:04:03]

Dry run: This issue passed the CQ dry run.

[scottmg, 2017-03-08 22:28:44]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2017-03-08 22:29:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 22:36:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489012124092240,
"parent_rev": "a86006db0adbe5bda6789d2a14d0805ce6273596", "commit_rev":
"eae0bca61d34738c1386c4d34ea4a3588b4dc8df"}

[commit-bot: I haz the power, 2017-03-08 22:36:51]

Description was changed from

==========
Change ui/base/l10n/formatter LazyInstance to Leaky

I don't believe destroying the FormatterContainer, or its contained
Formatter, or their contained icu::MessageFormat is important either at
process shutdown, or in between tests.

TEST=ui_base_unittests --gtest_repeat=100 --gtest_shuffle
R=jshin@chromium.org
BUG=698982
==========

to

==========
Change ui/base/l10n/formatter LazyInstance to Leaky

I don't believe destroying the FormatterContainer, or its contained
Formatter, or their contained icu::MessageFormat is important either at
process shutdown, or in between tests.

TEST=ui_base_unittests --gtest_repeat=100 --gtest_shuffle
R=jshin@chromium.org
BUG=698982

Review-Url: https://codereview.chromium.org/2742463002
Cr-Commit-Position: refs/heads/master@{#455561}
Committed:
https://chromium.googlesource.com/chromium/src/+/eae0bca61d34738c1386c4d34ea4...
==========

[commit-bot: I haz the power, 2017-03-08 22:36:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eae0bca61d34738c1386c4d34ea4...