Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2742453003: webkitpy: Simplify DiffParser, removing support for SVN patches. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Simplify DiffParser, removing support for SVN patches. BUG=676012 Review-Url: https://codereview.chromium.org/2742453003 Cr-Commit-Position: refs/heads/master@{#455629} Committed: https://chromium.googlesource.com/chromium/src/+/422f33f14f31a2aefee0fea84659dce7b61f6bc0

Patch Set 1 #

Patch Set 2 : Simplify PatchReader. #

Patch Set 3 : Re-add accidentally-removed baseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -212 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser.py View 3 chunks +5 lines, -51 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/diff_parser_unittest.py View 2 chunks +28 lines, -102 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/patchreader.py View 1 2 chunks +2 lines, -15 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/patchreader_unittest.py View 1 2 chunks +32 lines, -44 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
qyearsley
3 years, 9 months ago (2017-03-08 19:40:52 UTC) #2
jeffcarp
lgtm
3 years, 9 months ago (2017-03-08 21:28:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742453003/40001
3 years, 9 months ago (2017-03-09 00:20:21 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 01:42:40 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/422f33f14f31a2aefee0fea84659...

Powered by Google App Engine
This is Rietveld 408576698