Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2742433002: 📰 Do not refresh Tiles while visible (Closed)
Patch Set: move loadTiles with other private methods Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
index 7bb207bb7fc30478fcdf4231e7535ddb2f0832cc..6ef26eb29d8abb19676b8e7ff49532614d251468 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
@@ -47,6 +47,8 @@
@Nullable
private final AboveTheFoldItem mAboveTheFold;
+ @Nullable
+ private final TileGrid mTileGrid;
private final SectionList mSections;
private final SignInPromo mSigninPromo;
private final AllDismissedItem mAllDismissed;
@@ -85,9 +87,12 @@ public NewTabPageAdapter(SuggestionsUiDelegate uiDelegate, @Nullable View aboveT
mAboveTheFold = new AboveTheFoldItem();
mRoot.addChild(mAboveTheFold);
}
- if (tileGroupDelegate != null) {
- mRoot.addChild(new TileGrid(
- uiDelegate, mContextMenuManager, tileGroupDelegate, offlinePageBridge));
+ if (tileGroupDelegate == null) {
+ mTileGrid = null;
+ } else {
+ mTileGrid = new TileGrid(
+ uiDelegate, mContextMenuManager, tileGroupDelegate, offlinePageBridge);
+ mRoot.addChild(mTileGrid);
}
mRoot.addChildren(mSections, mSigninPromo, mAllDismissed, mFooter);
if (mAboveTheFoldView == null
@@ -181,6 +186,7 @@ public void refreshSuggestions() {
// The NTP Tiles already update when changes occurs, they don't need to be explicitly reset,
// unlike the cards.
mSections.refreshSuggestions();
+ if (mTileGrid != null) mTileGrid.getTileGroup().onSwitchToForeground();
}
public int getAboveTheFoldPosition() {

Powered by Google App Engine
This is Rietveld 408576698