Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2797)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2742433002: 📰 Do not refresh Tiles while visible (Closed)
Patch Set: move loadTiles with other private methods Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index 6317e6e0a463903d322b3520c44361c8c4a1e5b9..c833e891153f96956274def1610a2c790249cd9e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -44,6 +44,7 @@
import org.chromium.chrome.browser.suggestions.Tile;
import org.chromium.chrome.browser.suggestions.TileGridLayout;
import org.chromium.chrome.browser.suggestions.TileGroup;
+import org.chromium.chrome.browser.tab.EmptyTabObserver;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.util.FeatureUtilities;
import org.chromium.chrome.browser.util.MathUtils;
@@ -235,6 +236,12 @@ public void onDestroy() {
mNewTabPageLayout.addOnLayoutChangeListener(this);
setSearchProviderHasLogo(searchProviderHasLogo);
+ tab.addObserver(new EmptyTabObserver() {
+ @Override
+ public void onShown(Tab tab) {
+ mTileGroup.onSwitchToForeground();
+ }
+ });
mTileGroup.startObserving(getMaxTileRows(searchProviderHasLogo) * getMaxTileColumns());
// Set up snippets
@@ -417,6 +424,11 @@ public View getPlaceholder() {
return mTileGridPlaceholder;
}
+ @VisibleForTesting
+ public TileGroup getTileGroup() {
+ return mTileGroup;
+ }
+
/**
* Adds listeners to scrolling to take care of snap scrolling and updating the search box on
* scroll.

Powered by Google App Engine
This is Rietveld 408576698