Adhere to the Android Payment app spec.

Adhere to the Android Payment app spec.

Spec:
https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE

Changes:
1) Pass "methodNames" list to the payment app.
2) Pass "dataMap" list to the payment app.

BUG=700932
Review-Url: https://codereview.chromium.org/2742413002
Cr-Commit-Position: refs/heads/master@{#457883}
Committed: https://chromium.googlesource.com/chromium/src/+/7f27d3a538e1b0244723630dd221a14e935f28ba

[please use gerrit instead, 2017-03-13 19:57:23]

rouslan@chromium.org changed reviewers:
+ gogerald@chromium.org

[please use gerrit instead, 2017-03-13 19:57:24]

Ganggui, ptal.

[gogerald1, 2017-03-15 14:48:45]

lgtm with comments and questions,

https://codereview.chromium.org/2742413002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2742413002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:245:
@Nullable final byte[][] certificateChain,
update the spec doc? and also annotate this variable in PaymentRequestImpl? When
certificateChain == null? do we allow this?

https://codereview.chromium.org/2742413002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:314:
@Nullable Map<String, PaymentDetailsModifier> modifiers) {
either remove |modifiers| from this interface or add it to Bundle?

[please use gerrit instead, 2017-03-17 20:12:52]

https://codereview.chromium.org/2742413002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2742413002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:245:
@Nullable final byte[][] certificateChain,
On 2017/03/15 14:48:45, gogerald1 wrote:
> update the spec doc?

Done.

> and also annotate this variable in PaymentRequestImpl?

Done.

> When certificateChain == null?

When calling PaymentRequest from localhost or a file on disk. These two are
secure contexts that do not have SSL certificates.

> do we allow this? 

Yep.

https://codereview.chromium.org/2742413002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:314:
@Nullable Map<String, PaymentDetailsModifier> modifiers) {
On 2017/03/15 14:48:45, gogerald1 wrote:
> either remove |modifiers| from this interface or add it to Bundle?

Modifiers should be passed to the payment apps only after we display them in UI.
Otherwise the user is not aware of 100% of the transaction details. That's still
to be done. (I hope soon.)

[please use gerrit instead, 2017-03-17 20:13:22]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-03-17 20:13:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
gogerald@chromium.org
Link to the patchset: https://codereview.chromium.org/2742413002/#ps60001
(title: "Comments")

[commit-bot: I haz the power, 2017-03-17 20:13:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 20:54:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489781602913090,
"parent_rev": "481b60f33d1b0985a3bce0ea0b55a9d054add218", "commit_rev":
"7f27d3a538e1b0244723630dd221a14e935f28ba"}

[commit-bot: I haz the power, 2017-03-17 20:55:22]

Description was changed from

==========
Adhere to the Android Payment app spec.

Spec:
https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE

Changes:
1) Pass "methodNames" list to the payment app.
2) Pass "dataMap" list to the payment app.

BUG=700932
==========

to

==========
Adhere to the Android Payment app spec.

Spec:
https://docs.google.com/document/d/1izV4uC-tiRJG3JLooqY3YRLU22tYOsLTNq0P_InPJeE

Changes:
1) Pass "methodNames" list to the payment app.
2) Pass "dataMap" list to the payment app.

BUG=700932

Review-Url: https://codereview.chromium.org/2742413002
Cr-Commit-Position: refs/heads/master@{#457883}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f27d3a538e1b0244723630dd221...
==========

[commit-bot: I haz the power, 2017-03-17 20:55:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7f27d3a538e1b0244723630dd221...