Limit the amount the Location Settings Dialog will be shown to users.

chrome/browser/permissions/permission_context_base.h

Index: chrome/browser/permissions/permission_context_base.h
diff --git a/chrome/browser/permissions/permission_context_base.h b/chrome/browser/permissions/permission_context_base.h
index 066f7a5a8409c80f3b680eca98c619af20cc6e4b..d0ee7480fb9c17e01ae44c9016dfb3636a766a95 100644
--- a/chrome/browser/permissions/permission_context_base.h
+++ b/chrome/browser/permissions/permission_context_base.h
@@ -129,13 +129,13 @@ class PermissionContextBase : public KeyedService {
                                 const BrowserPermissionCallback& callback);
 
   // Called when permission is granted without interactively asking the user.
-  void PermissionDecided(const PermissionRequestID& id,
-                         const GURL& requesting_origin,
-                         const GURL& embedding_origin,
-                         bool user_gesture,
-                         const BrowserPermissionCallback& callback,
-                         bool persist,
-                         ContentSetting content_setting);
+  virtual void PermissionDecided(const PermissionRequestID& id,
+                                 const GURL& requesting_origin,
+                                 const GURL& embedding_origin,
+                                 bool user_gesture,
+                                 const BrowserPermissionCallback& callback,
+                                 bool persist,
+                                 ContentSetting content_setting);

[raymes, 2017/03/15 04:28:25]

Thinking more about why this doesn't feel great to me: I think it's because it's
easy for people to break assumptions by overriding this. Specifically, if you
don't call back into the base class to get the base class behavior, then you end
up breaking all the metrics and dismissal-embargoing behavior.

By overriding a function that does nothing at the base level there is no risk of
that. What are your thoughts? 

[benwells, 2017/03/15 23:10:49]

Done.

 
   virtual void NotifyPermissionSet(const PermissionRequestID& id,
                                    const GURL& requesting_origin,