Limit the amount the Location Settings Dialog will be shown to users.

chrome/browser/permissions/permission_context_base.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_CONTEXT_BASE_H_
 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_CONTEXT_BASE_H_
 
 #include <memory>
 #include <unordered_map>
 
@@ skipping 111 matching lines @@
   // Calls PermissionDecided if permission can be decided non-interactively,
   // or NotifyPermissionSet if permission decided by presenting an infobar.
   virtual void DecidePermission(content::WebContents* web_contents,
                                 const PermissionRequestID& id,
                                 const GURL& requesting_origin,
                                 const GURL& embedding_origin,
                                 bool user_gesture,
                                 const BrowserPermissionCallback& callback);
 
   // Called when permission is granted without interactively asking the user.
-  void PermissionDecided(const PermissionRequestID& id,
-                         const GURL& requesting_origin,
-                         const GURL& embedding_origin,
-                         bool user_gesture,
-                         const BrowserPermissionCallback& callback,
-                         bool persist,
-                         ContentSetting content_setting);
+  virtual void PermissionDecided(const PermissionRequestID& id,
+                                 const GURL& requesting_origin,
+                                 const GURL& embedding_origin,
+                                 bool user_gesture,
+                                 const BrowserPermissionCallback& callback,
+                                 bool persist,
+                                 ContentSetting content_setting);

[raymes, 2017/03/15 04:28:25]

Thinking more about why this doesn't feel great to me: I think it's because it's
easy for people to break assumptions by overriding this. Specifically, if you
don't call back into the base class to get the base class behavior, then you end
up breaking all the metrics and dismissal-embargoing behavior.

By overriding a function that does nothing at the base level there is no risk of
that. What are your thoughts? 

[benwells, 2017/03/15 23:10:49]

Done.

 
   virtual void NotifyPermissionSet(const PermissionRequestID& id,
                                    const GURL& requesting_origin,
                                    const GURL& embedding_origin,
                                    const BrowserPermissionCallback& callback,
                                    bool persist,
                                    ContentSetting content_setting);
 
   // Implementors can override this method to update the icons on the
   // url bar with the result of the new permission.
@@ skipping 52 matching lines @@
 #endif
   std::unordered_map<std::string, std::unique_ptr<PermissionRequest>>
       pending_requests_;
 
   // Must be the last member, to ensure that it will be
   // destroyed first, which will invalidate weak pointers
   base::WeakPtrFactory<PermissionContextBase> weak_factory_;
 };
 
 #endif  // CHROME_BROWSER_PERMISSIONS_PERMISSION_CONTEXT_BASE_H_