Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2742343005: PPC/s390: [builtins] Port TypedArrayConstructByArrayBuffer to CodeStubAssembler. (Closed)

Created:
3 years, 9 months ago by JaideepBajwa
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] Port TypedArrayConstructByArrayBuffer to CodeStubAssembler. Port 06fef85bdd2db7418b75c4f64ac164f3fbe90e30 Original Commit Message: Part of the performance and refactoring work to move the TypedArray constructors into CSA. This CL moves ConstructByArrayBuffer from JS to CSA. R=petermarshall@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5977 LOG=N Review-Url: https://codereview.chromium.org/2742343005 Cr-Commit-Position: refs/heads/master@{#43756} Committed: https://chromium.googlesource.com/v8/v8/+/d3f236fa054413e9a81c95aef620605968282a82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 9 months ago (2017-03-13 18:32:44 UTC) #1
john.yan
lgtm
3 years, 9 months ago (2017-03-13 18:34:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742343005/1
3 years, 9 months ago (2017-03-13 18:42:54 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 19:18:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d3f236fa054413e9a81c95aef6206059682...

Powered by Google App Engine
This is Rietveld 408576698