Remove ScopedVector from content/browser/ [1].

Remove ScopedVector from content/browser/ [1].

base::ScopedVector is deprecated, see bug.

This is the 1st CL for content/browser/, partly removes ScopedVector.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2742333002
Cr-Commit-Position: refs/heads/master@{#456600}
Committed: https://chromium.googlesource.com/chromium/src/+/874a5ffba8b970a0442515430205e6210a04a359

[leonhsl(Using Gerrit), 2017-03-13 11:36:50]

Description was changed from

==========
Remove ScopedVector from content/browser/ [1].

base::ScopedVector is deprecated, see bug.

This is the 1st CL for content/browser/, partly removes ScopedVector.

BUG=554289
==========

to

==========
Remove ScopedVector from content/browser/ [1].

base::ScopedVector is deprecated, see bug.

This is the 1st CL for content/browser/, partly removes ScopedVector.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[leonhsl(Using Gerrit), 2017-03-13 11:37:05]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 11:37:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 11:44:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 11:44:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[leonhsl(Using Gerrit), 2017-03-13 14:02:51]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 14:03:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-03-13 14:03:53]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-03-13 14:14:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 14:14:51]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[leonhsl(Using Gerrit), 2017-03-13 14:52:11]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 14:52:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2017-03-13 14:58:44]

Patchset #1 (id:20001) has been deleted

[leonhsl(Using Gerrit), 2017-03-13 15:03:23]

leon.han@intel.com changed reviewers:
+ avi@chromium.org

[leonhsl(Using Gerrit), 2017-03-13 15:03:24]

PTAL, Thanks.
# content/browser/ have so many ScopedVector, to avoid too big CL, I'd like to
complete it with 2 or 3 CLs, this is the first one.

[Avi (use Gerrit), 2017-03-13 15:23:35]

lgtm

https://codereview.chromium.org/2742333002/diff/40001/content/browser/media/a...
File content/browser/media/android/browser_media_player_manager.cc (right):

https://codereview.chromium.org/2742333002/diff/40001/content/browser/media/a...
content/browser/media/android/browser_media_player_manager.cc:91:
std::unique_ptr<MediaPlayerAndroid> media_player_bridge(
Not MakeUnique? :(

https://codereview.chromium.org/2742333002/diff/40001/content/browser/media/a...
content/browser/media/android/browser_media_player_manager.cc:153:
player.release()->DeleteOnCorrectThread();
This is... odd, but no worse than before.

[commit-bot: I haz the power, 2017-03-13 16:03:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 16:03:33]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2017-03-14 02:17:12]

Thanks! Will send to CQ now.

https://codereview.chromium.org/2742333002/diff/40001/content/browser/media/a...
File content/browser/media/android/browser_media_player_manager.cc (right):

https://codereview.chromium.org/2742333002/diff/40001/content/browser/media/a...
content/browser/media/android/browser_media_player_manager.cc:91:
std::unique_ptr<MediaPlayerAndroid> media_player_bridge(
On 2017/03/13 15:23:34, Avi wrote:
> Not MakeUnique? :(

I was using MakeUnique, but trybots compile failed, because MakeUnique would
just create a std::unique_ptr<MediaPlayerBridge>, which can't be casted
automatically to a std::unique_ptr<MediaPlayerAndroid> expected to be returned
by CreateMediaPlayer(). So I changed to such a way..

[leonhsl(Using Gerrit), 2017-03-14 02:17:29]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2017-03-14 02:18:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 03:00:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489457849499160,
"parent_rev": "a4ba86c4ded6b80b488540a4b92de168b7bfe07c", "commit_rev":
"874a5ffba8b970a0442515430205e6210a04a359"}

[commit-bot: I haz the power, 2017-03-14 03:01:07]

Description was changed from

==========
Remove ScopedVector from content/browser/ [1].

base::ScopedVector is deprecated, see bug.

This is the 1st CL for content/browser/, partly removes ScopedVector.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove ScopedVector from content/browser/ [1].

base::ScopedVector is deprecated, see bug.

This is the 1st CL for content/browser/, partly removes ScopedVector.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2742333002
Cr-Commit-Position: refs/heads/master@{#456600}
Committed:
https://chromium.googlesource.com/chromium/src/+/874a5ffba8b970a0442515430205...
==========

[commit-bot: I haz the power, 2017-03-14 03:01:08]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/874a5ffba8b970a0442515430205...

[danakj, 2017-03-14 15:09:55]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2017-03-14 15:09:55]

https://codereview.chromium.org/2742333002/diff/40001/content/browser/media/a...
File content/browser/media/android/browser_media_player_manager.cc (right):

https://codereview.chromium.org/2742333002/diff/40001/content/browser/media/a...
content/browser/media/android/browser_media_player_manager.cc:91:
std::unique_ptr<MediaPlayerAndroid> media_player_bridge(
On 2017/03/14 02:17:12, leonhsl wrote:
> On 2017/03/13 15:23:34, Avi wrote:
> > Not MakeUnique? :(
> 
> I was using MakeUnique, but trybots compile failed, because MakeUnique would
> just create a std::unique_ptr<MediaPlayerBridge>, which can't be casted
> automatically to a std::unique_ptr<MediaPlayerAndroid> expected to be returned
> by CreateMediaPlayer(). So I changed to such a way..

Just cast it when you return

class B : public A {};

unique_ptr<A> f() {
  auto b = base::MakeUnique<B>();
  return std::move(b);
}

[danakj, 2017-03-14 15:10:07]

Description was changed from

==========
Remove ScopedVector from content/browser/ [1].

base::ScopedVector is deprecated, see bug.

This is the 1st CL for content/browser/, partly removes ScopedVector.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2742333002
Cr-Commit-Position: refs/heads/master@{#456600}
Committed:
https://chromium.googlesource.com/chromium/src/+/874a5ffba8b970a0442515430205...
==========

to

==========
Remove ScopedVector from content/browser/ [1].

base::ScopedVector is deprecated, see bug.

This is the 1st CL for content/browser/, partly removes ScopedVector.

BUG=554289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2742333002
Cr-Commit-Position: refs/heads/master@{#456600}
Committed:
https://chromium.googlesource.com/chromium/src/+/874a5ffba8b970a0442515430205...
==========

[danakj, 2017-03-14 15:10:07]

danakj@chromium.org changed reviewers:
- danakj@chromium.org

[leonhsl(Using Gerrit), 2017-03-15 02:50:11]

On 2017/03/14 15:09:55, danakj wrote:
>
https://codereview.chromium.org/2742333002/diff/40001/content/browser/media/a...
> File content/browser/media/android/browser_media_player_manager.cc (right):
> 
>
https://codereview.chromium.org/2742333002/diff/40001/content/browser/media/a...
> content/browser/media/android/browser_media_player_manager.cc:91:
> std::unique_ptr<MediaPlayerAndroid> media_player_bridge(
> On 2017/03/14 02:17:12, leonhsl wrote:
> > On 2017/03/13 15:23:34, Avi wrote:
> > > Not MakeUnique? :(
> > 
> > I was using MakeUnique, but trybots compile failed, because MakeUnique would
> > just create a std::unique_ptr<MediaPlayerBridge>, which can't be casted
> > automatically to a std::unique_ptr<MediaPlayerAndroid> expected to be
returned
> > by CreateMediaPlayer(). So I changed to such a way..
> 
> Just cast it when you return
> 
> class B : public A {};
> 
> unique_ptr<A> f() {
>   auto b = base::MakeUnique<B>();
>   return std::move(b);
> }

Thanks! I'll prepare a CL to fix this.

[leonhsl(Using Gerrit), 2017-03-15 05:21:59]

On 2017/03/15 02:50:11, leonhsl wrote:
> On 2017/03/14 15:09:55, danakj wrote:
> >
>
https://codereview.chromium.org/2742333002/diff/40001/content/browser/media/a...
> > File content/browser/media/android/browser_media_player_manager.cc (right):
> > 
> >
>
https://codereview.chromium.org/2742333002/diff/40001/content/browser/media/a...
> > content/browser/media/android/browser_media_player_manager.cc:91:
> > std::unique_ptr<MediaPlayerAndroid> media_player_bridge(
> > On 2017/03/14 02:17:12, leonhsl wrote:
> > > On 2017/03/13 15:23:34, Avi wrote:
> > > > Not MakeUnique? :(
> > > 
> > > I was using MakeUnique, but trybots compile failed, because MakeUnique
would
> > > just create a std::unique_ptr<MediaPlayerBridge>, which can't be casted
> > > automatically to a std::unique_ptr<MediaPlayerAndroid> expected to be
> returned
> > > by CreateMediaPlayer(). So I changed to such a way..
> > 
> > Just cast it when you return
> > 
> > class B : public A {};
> > 
> > unique_ptr<A> f() {
> >   auto b = base::MakeUnique<B>();
> >   return std::move(b);
> > }
> 
> Thanks! I'll prepare a CL to fix this.

https://codereview.chromium.org/2749203002/ fixes this.