Add ConstantUse to WorldImpact

Add ConstantUse to WorldImpact

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/5ec55890fac4e985110bbefeb84b9aaf978b48f4

[Johnni Winther, 2017-03-13 11:24:09]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2017-03-13 11:24:10]

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/mirrors_data.dart (right):

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/mirrors_data.dart:184: if (cls ==
_helpers.jsIntClass) {
A fix from another CL.

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/member_usage.dart (right):

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/member_usage.dart:261: return
_pendingUse.removeAll(MemberUses.NORMAL_ONLY);
A fix from another CL.

[Siggi Cherem (dart-lang), 2017-03-14 05:43:59]

lgtm! really nice to see constants finally modeled by the impacts

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart (right):

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart:174: final
StagedWorldImpactBuilder _impactBuilder =
never mind my comment from the other CL :)

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart:326:
_impactBuilder.registerStaticUse(new StaticUse.staticInvoke(
in any way does the move to impacts address the TODO above? (could we drop this
extra impact registration now?)

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart:328:
_helpers.createRuntimeType,
I thought this would actually register typeType as before.... something like:
    impactBuilder.registerTypeUse(new
TypeUse.instantiation(_backendClasses.typeType));

?

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/mirrors_data.dart (right):

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/mirrors_data.dart:184: if (cls ==
_helpers.jsIntClass) {
On 2017/03/13 11:24:10, Johnni Winther wrote:
> A fix from another CL.

this is the CL you landed separately, correct?

[Johnni Winther, 2017-03-15 13:15:43]

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart (right):

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart:174: final
StagedWorldImpactBuilder _impactBuilder =
On 2017/03/14 05:43:59, Siggi Cherem (dart-lang) wrote:
> never mind my comment from the other CL :)

Acknowledged.

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart:326:
_impactBuilder.registerStaticUse(new StaticUse.staticInvoke(
On 2017/03/14 05:43:59, Siggi Cherem (dart-lang) wrote:
> in any way does the move to impacts address the TODO above? (could we drop
this
> extra impact registration now?)

It doesn't :( I'm still investigating.

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart:328:
_helpers.createRuntimeType,
On 2017/03/14 05:43:59, Siggi Cherem (dart-lang) wrote:
> I thought this would actually register typeType as before.... something like:
>     impactBuilder.registerTypeUse(new
> TypeUse.instantiation(_backendClasses.typeType));
> 
> ?

This is the inlined version of computeImpactForInstantiatedConstantType.
[_backendClasses.typeType] was just the trigger.

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/mirrors_data.dart (right):

https://codereview.chromium.org/2742283002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/mirrors_data.dart:184: if (cls ==
_helpers.jsIntClass) {
On 2017/03/14 05:43:59, Siggi Cherem (dart-lang) wrote:
> On 2017/03/13 11:24:10, Johnni Winther wrote:
> > A fix from another CL.
> 
> this is the CL you landed separately, correct?

Yes.

[Johnni Winther, 2017-03-15 13:34:46]

Description was changed from

==========
Add ConstantUse to WorldImpact
==========

to

==========
Add ConstantUse to WorldImpact

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5ec55890fac4e985110bbefeb84b9aaf978b48f4
==========

[Johnni Winther, 2017-03-15 13:34:47]

Committed patchset #2 (id:20001) manually as
5ec55890fac4e985110bbefeb84b9aaf978b48f4 (presubmit successful).