Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: pkg/compiler/lib/src/js_backend/impact_transformer.dart

Issue 2742283002: Add ConstantUse to WorldImpact (Closed)
Patch Set: Cleanup. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/impact_transformer.dart
diff --git a/pkg/compiler/lib/src/js_backend/impact_transformer.dart b/pkg/compiler/lib/src/js_backend/impact_transformer.dart
index 1c6312e4e351b53666657d47ea08846cc93d6dde..b3e04547ce036bb35015c3947ffdc2db6fd3ebcf 100644
--- a/pkg/compiler/lib/src/js_backend/impact_transformer.dart
+++ b/pkg/compiler/lib/src/js_backend/impact_transformer.dart
@@ -20,7 +20,7 @@ import '../native/native.dart' as native;
import '../options.dart';
import '../universe/feature.dart';
import '../universe/use.dart'
- show StaticUse, StaticUseKind, TypeUse, TypeUseKind;
+ show ConstantUse, StaticUse, StaticUseKind, TypeUse, TypeUseKind;
import '../universe/world_impact.dart' show TransformedWorldImpact, WorldImpact;
import '../util/util.dart';
import 'backend.dart';
@@ -334,9 +334,6 @@ class JavaScriptImpactTransformer extends ImpactTransformer {
}
class CodegenImpactTransformer {
- // TODO(johnniwinther): Remove this need for this.
- final JavaScriptBackend _backend;
-
final CompilerOptions _options;
final ElementEnvironment _elementEnvironment;
final BackendHelpers _helpers;
@@ -350,9 +347,9 @@ class CodegenImpactTransformer {
final OneShotInterceptorData _oneShotInterceptorData;
final LookupMapAnalysis _lookupMapAnalysis;
final CustomElementsCodegenAnalysis _customElementsCodegenAnalysis;
+ final RuntimeTypesChecksBuilder _rtiChecksBuilder;
CodegenImpactTransformer(
- this._backend,
this._options,
this._elementEnvironment,
this._helpers,
@@ -365,7 +362,8 @@ class CodegenImpactTransformer {
this._mirrorsData,
this._oneShotInterceptorData,
this._lookupMapAnalysis,
- this._customElementsCodegenAnalysis);
+ this._customElementsCodegenAnalysis,
+ this._rtiChecksBuilder);
void onIsCheckForCodegen(
ResolutionDartType type, TransformedWorldImpact transformed) {
@@ -424,15 +422,10 @@ class CodegenImpactTransformer {
}
}
- for (ConstantValue constant in impact.compileTimeConstants) {
- _backend.computeImpactForCompileTimeConstant(constant, transformed,
- forResolution: false);
- _backend.addCompileTimeConstantForEmission(constant);
- }
-
for (Pair<ResolutionDartType, ResolutionDartType> check
in impact.typeVariableBoundsSubtypeChecks) {
- _backend.registerTypeVariableBoundsSubtypeCheck(check.a, check.b);
+ _rtiChecksBuilder.registerTypeVariableBoundsSubtypeCheck(
+ check.a, check.b);
}
for (StaticUse staticUse in impact.staticUses) {

Powered by Google App Engine
This is Rietveld 408576698