Move cursor property to be generated in ComputedStyleBase.

Move cursor property to be generated in ComputedStyleBase.

Move the inherited property 'cursor' and its enum, ECursor,
to be generated in ComputedStyleBase. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase. Finally
replaced handwritten conversion between CSSValueID and ECursor with
generated code.

Note that this renames m_cursorStyle to m_cursor to match
the name of the getter/setter. This shouldn't affect anything
since the member is private and only used within the generated
class.

The changes in generated code is triggered by adding the 'keyword'
field_template to the cursor property in CSSProperties.json5.

Diff: https://gist.github.com/darrnshn/2a3770b1721a7354110633a5ea6fcec1/revisions

BUG=628043
Review-Url: https://codereview.chromium.org/2742253002
Cr-Commit-Position: refs/heads/master@{#458012}
Committed: https://chromium.googlesource.com/chromium/src/+/9101b588bd21687dac9f733f817d283dcac0d1de

[shend, 2017-03-13 05:43:21]

Description was changed from

==========
Move cursor property to be generated in ComputedStyleBase.

Move the inherited property 'cursor' and its enum, ECursor,
to be generated in ComputedStyleBase. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase. Finally
replaced handwritten conversion between CSSValueID and ECursor with
generated code.

Note that this renames m_cursorStyle to m_cursor to match
the name of the getter/setter. This shouldn't affect anything
since the member is private and only used within the generated
class.

BUG=628043
==========

to

==========
Move cursor property to be generated in ComputedStyleBase.

Move the inherited property 'cursor' and its enum, ECursor,
to be generated in ComputedStyleBase. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase. Finally
replaced handwritten conversion between CSSValueID and ECursor with
generated code.

Note that this renames m_cursorStyle to m_cursor to match
the name of the getter/setter. This shouldn't affect anything
since the member is private and only used within the generated
class.

Diff: https://gist.github.com/darrnshn/2a3770b1721a7354110633a5ea6fcec1

BUG=628043
==========

[shend, 2017-03-13 05:43:45]

Description was changed from

==========
Move cursor property to be generated in ComputedStyleBase.

Move the inherited property 'cursor' and its enum, ECursor,
to be generated in ComputedStyleBase. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase. Finally
replaced handwritten conversion between CSSValueID and ECursor with
generated code.

Note that this renames m_cursorStyle to m_cursor to match
the name of the getter/setter. This shouldn't affect anything
since the member is private and only used within the generated
class.

Diff: https://gist.github.com/darrnshn/2a3770b1721a7354110633a5ea6fcec1

BUG=628043
==========

to

==========
Move cursor property to be generated in ComputedStyleBase.

Move the inherited property 'cursor' and its enum, ECursor,
to be generated in ComputedStyleBase. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase. Finally
replaced handwritten conversion between CSSValueID and ECursor with
generated code.

Note that this renames m_cursorStyle to m_cursor to match
the name of the getter/setter. This shouldn't affect anything
since the member is private and only used within the generated
class.

Diff:
https://gist.github.com/darrnshn/2a3770b1721a7354110633a5ea6fcec1/revisions

BUG=628043
==========

[shend, 2017-03-13 05:44:15]

shend@chromium.org changed reviewers:
+ bugsnash@chromium.org

[shend, 2017-03-13 05:44:15]

Hi Bugs, PTAL :)

[Bugs Nash, 2017-03-13 23:25:13]

On 2017/03/13 at 05:44:15, shend wrote:
> Hi Bugs, PTAL :)

Please add to CL description how this patch causes generated code (I'm guessing
it's from adding the keyword details to CSSProperties.json5).

I'm confused about the extra code that is now being generated in
ComputedStyleBase.h - for example, why is it that the new generated file
includes cursor in the copy constructor, where this doesn't seem to have been
included in either copy constructor previously?

Also the linked gist seems to include new files that it shouldn't (duplicated
from edited files).

[shend, 2017-03-13 23:29:59]

Description was changed from

==========
Move cursor property to be generated in ComputedStyleBase.

Move the inherited property 'cursor' and its enum, ECursor,
to be generated in ComputedStyleBase. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase. Finally
replaced handwritten conversion between CSSValueID and ECursor with
generated code.

Note that this renames m_cursorStyle to m_cursor to match
the name of the getter/setter. This shouldn't affect anything
since the member is private and only used within the generated
class.

Diff:
https://gist.github.com/darrnshn/2a3770b1721a7354110633a5ea6fcec1/revisions

BUG=628043
==========

to

==========
Move cursor property to be generated in ComputedStyleBase.

Move the inherited property 'cursor' and its enum, ECursor,
to be generated in ComputedStyleBase. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase. Finally
replaced handwritten conversion between CSSValueID and ECursor with
generated code.

Note that this renames m_cursorStyle to m_cursor to match
the name of the getter/setter. This shouldn't affect anything
since the member is private and only used within the generated
class.

The changes in generated code is triggered by adding the 'keyword'
field_template to the cursor property in CSSProperties.json5.

Diff:
https://gist.github.com/darrnshn/2a3770b1721a7354110633a5ea6fcec1/revisions

BUG=628043
==========

[shend, 2017-03-13 23:33:09]

On 2017/03/13 at 23:25:13, bugsnash wrote:
> On 2017/03/13 at 05:44:15, shend wrote:
> > Hi Bugs, PTAL :)
> 
> Please add to CL description how this patch causes generated code (I'm
guessing it's from adding the keyword details to CSSProperties.json5).

Done.

> I'm confused about the extra code that is now being generated in
ComputedStyleBase.h - for example, why is it that the new generated file
includes cursor in the copy constructor, where this doesn't seem to have been
included in either copy constructor previously?

Previously, cursor was copied via the implicitly-defined copy constructor on
inheritedData. The generated code just copies the member directly.

> Also the linked gist seems to include new files that it shouldn't (duplicated
from edited files).

Unfortunately this is a problem with Gist. The revisions page that I linked to
actually contains the diffs for 2 revisions one after the other. If you search
"revised" and then "created" on the page, you'll see the two revisions, which
explains why there's two copies of each file. There's currently no way to link
to a particular revision on GitHub :(

[Bugs Nash, 2017-03-13 23:39:15]

On 2017/03/13 at 23:33:09, shend wrote:
> On 2017/03/13 at 23:25:13, bugsnash wrote:
> > On 2017/03/13 at 05:44:15, shend wrote:
> > > Hi Bugs, PTAL :)
> > 
> > Please add to CL description how this patch causes generated code (I'm
guessing it's from adding the keyword details to CSSProperties.json5).
> 
> Done.
> 
> > I'm confused about the extra code that is now being generated in
ComputedStyleBase.h - for example, why is it that the new generated file
includes cursor in the copy constructor, where this doesn't seem to have been
included in either copy constructor previously?
> 
> Previously, cursor was copied via the implicitly-defined copy constructor on
inheritedData. The generated code just copies the member directly.

I see. Add that info to the description too plz. lgtm!


> 
> > Also the linked gist seems to include new files that it shouldn't
(duplicated from edited files).
> 
> Unfortunately this is a problem with Gist. The revisions page that I linked to
actually contains the diffs for 2 revisions one after the other. If you search
"revised" and then "created" on the page, you'll see the two revisions, which
explains why there's two copies of each file. There's currently no way to link
to a particular revision on GitHub :(

[shend, 2017-03-16 22:10:13]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-03-16 22:10:13]

Hi Eddy, PTAL

[meade_UTC10, 2017-03-17 06:41:24]

lgtm

\o/

[shend, 2017-03-19 21:15:34]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-03-19 21:15:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-19 21:15:44]

This CL has an open dependency (Issue 2686473004 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[shend, 2017-03-19 21:25:23]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-19 21:25:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-19 23:55:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-19 23:55:33]

Dry run: This issue passed the CQ dry run.

[shend, 2017-03-20 00:03:41]

The CQ bit was checked by shend@chromium.org

[shend, 2017-03-20 00:03:42]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2742253002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-20 00:03:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 00:10:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 00:11:00]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[shend, 2017-03-20 00:44:23]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 00:44:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 02:08:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 02:08:20]

Dry run: This issue passed the CQ dry run.

[shend, 2017-03-20 02:13:50]

The CQ bit was checked by shend@chromium.org

[shend, 2017-03-20 02:13:50]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org,
bugsnash@chromium.org
Link to the patchset: https://codereview.chromium.org/2742253002/#ps50006
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-20 02:13:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 02:17:49]

CQ is committing da patch.

Bot data: {"patchset_id": 50006, "attempt_start_ts": 1489976030034990,
"parent_rev": "ff2ee4a30a7b0170e27b227c11157b7844e79c99", "commit_rev":
"9101b588bd21687dac9f733f817d283dcac0d1de"}

[commit-bot: I haz the power, 2017-03-20 02:18:32]

Description was changed from

==========
Move cursor property to be generated in ComputedStyleBase.

Move the inherited property 'cursor' and its enum, ECursor,
to be generated in ComputedStyleBase. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase. Finally
replaced handwritten conversion between CSSValueID and ECursor with
generated code.

Note that this renames m_cursorStyle to m_cursor to match
the name of the getter/setter. This shouldn't affect anything
since the member is private and only used within the generated
class.

The changes in generated code is triggered by adding the 'keyword'
field_template to the cursor property in CSSProperties.json5.

Diff:
https://gist.github.com/darrnshn/2a3770b1721a7354110633a5ea6fcec1/revisions

BUG=628043
==========

to

==========
Move cursor property to be generated in ComputedStyleBase.

Move the inherited property 'cursor' and its enum, ECursor,
to be generated in ComputedStyleBase. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase. Finally
replaced handwritten conversion between CSSValueID and ECursor with
generated code.

Note that this renames m_cursorStyle to m_cursor to match
the name of the getter/setter. This shouldn't affect anything
since the member is private and only used within the generated
class.

The changes in generated code is triggered by adding the 'keyword'
field_template to the cursor property in CSSProperties.json5.

Diff:
https://gist.github.com/darrnshn/2a3770b1721a7354110633a5ea6fcec1/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2742253002
Cr-Commit-Position: refs/heads/master@{#458012}
Committed:
https://chromium.googlesource.com/chromium/src/+/9101b588bd21687dac9f733f817d...
==========

[commit-bot: I haz the power, 2017-03-20 02:18:33]

Committed patchset #4 (id:50006) as
https://chromium.googlesource.com/chromium/src/+/9101b588bd21687dac9f733f817d...