Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2742243002: input[type=range]: if min > max use min as default value. (Closed)

Created:
3 years, 9 months ago by MartinRogalla
Modified:
3 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

input[type=range]: if min > max use min as default value. This patch ensures that if the maximum attr of an <input type="range"> is less than the minimum attr, the minimum attr value is used as the default value. This is according to the specification in [1]. This patch fixes the 14th test in [2]. [1] - https://html.spec.whatwg.org/multipage/forms.html#concept-input-value-default-range [2] - http://w3c-test.org/html/semantics/forms/the-input-element/range.html BUG=699419 Review-Url: https://codereview.chromium.org/2742243002 Cr-Commit-Position: refs/heads/master@{#456327} Committed: https://chromium.googlesource.com/chromium/src/+/d9f7bd34b3431faf6ce077fc1d85b2335a722931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-input-element/range-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/RangeInputType.cpp View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
MartinRogalla
3 years, 9 months ago (2017-03-13 02:47:44 UTC) #1
tkent
lgtm
3 years, 9 months ago (2017-03-13 04:28:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742243002/1
3 years, 9 months ago (2017-03-13 04:29:03 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 05:36:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d9f7bd34b3431faf6ce077fc1d85...

Powered by Google App Engine
This is Rietveld 408576698