Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2742113002: Gate support for certain EOTFs/primaries/matrices on color management / hdr flags (Closed)

Created:
3 years, 9 months ago by hubbe
Modified:
3 years, 9 months ago
Reviewers:
chcunningham, ccameron
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gate support for certain EOTFs/primaries/matrices on color management / hdr flags Creates a new class VideoColorSpace specifically for encoding color spaces according to ISO/IEC 23001-8. Plumb this color space through from parsing to validation. BUG=687627 Review-Url: https://codereview.chromium.org/2742113002 Cr-Commit-Position: refs/heads/master@{#456518} Committed: https://chromium.googlesource.com/chromium/src/+/2fb4f2c9c461551d43fdfa28ef4c960da81a47dd

Patch Set 1 #

Patch Set 2 : missed updating some tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -206 lines) Patch
M content/renderer/media/render_media_client.cc View 3 chunks +92 lines, -12 lines 0 comments Download
M content/renderer/media/render_media_client_unittest.cc View 1 1 chunk +82 lines, -24 lines 0 comments Download
M media/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/media_client.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/base/mime_util_internal.h View 3 chunks +7 lines, -5 lines 0 comments Download
M media/base/mime_util_internal.cc View 10 chunks +16 lines, -14 lines 0 comments Download
M media/base/video_codecs.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/base/video_codecs.cc View 5 chunks +19 lines, -81 lines 0 comments Download
M media/base/video_codecs_unittest.cc View 3 chunks +71 lines, -68 lines 0 comments Download
A media/base/video_color_space.h View 1 chunk +102 lines, -0 lines 0 comments Download
A media/base/video_color_space.cc View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
hubbe
3 years, 9 months ago (2017-03-10 23:46:01 UTC) #3
chcunningham
LGTM! Awesome that color_space.h is doing this for us. I didn't realize the tables were ...
3 years, 9 months ago (2017-03-11 02:50:33 UTC) #7
ccameron
lgtm2
3 years, 9 months ago (2017-03-13 12:49:49 UTC) #8
ccameron
On 2017/03/13 12:49:49, ccameron wrote: > lgtm2 err, lgtm
3 years, 9 months ago (2017-03-13 12:50:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742113002/20001
3 years, 9 months ago (2017-03-13 20:58:00 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 22:53:53 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2fb4f2c9c461551d43fdfa28ef4c...

Powered by Google App Engine
This is Rietveld 408576698