Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2742083002: Revert of Re-land WebVR compositor bypass via BrowserMain context + mailbox (Closed)

Created:
3 years, 9 months ago by klausw
Modified:
3 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, haraken, Aaron Boodman, feature-vr-reviews_chromium.org, blink-reviews, darin (slow to review), blink-reviews-frames_chromium.org, jbauman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-land WebVR compositor bypass via BrowserMain context + mailbox (patchset #37 id:710001 of https://codereview.chromium.org/2729523002/ ) Reason for revert: Layout tests still failing for mac and windows despite passing on the trybots. Example: https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac10.9&number=43627 Original issue's description: > Re-land WebVR compositor bypass via BrowserMain context + mailbox > > Implement compositor bypass for WebVR via mailbox copy: > > - Create a GPU command buffer GL context in the VrShellGl thread that's > backed by a native Surface. This is encapsulated inside the new > MailboxToSurfaceBridge class. > > - WebKit's VRDisplay sends a MailboxHolder for each frame (as drawn > via WebGL on the GPU process) as argument to the SubmitFrame mojo > call. > > - MailboxToSurfaceLayerBridge uses its GPU command buffer GL context > to draw the mailbox content to a Surface. > > - VrShellGl picks up the frame from the corresponding SurfaceTexture > and proceeds with rendering as usual with its native GL context > as needed for the low-level GVR API. > > Also implements on-the-fly canvas resizing, the transfer surface and > GVR renderbuffer are resized as needed to match the source canvas. > > Added frame number as an argument to various TRACE_EVENTs for timing > analysis. > > It includes two separate modes for frame scheduling, the more > aggressive one is conditional on > chrome:://flags#enable-webvr-experimental-rendering since the > framerate seems a bit less stable. > > BUG=698643 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2729523002 > Cr-Original-Commit-Position: refs/heads/master@{#455592} > Committed: https://chromium.googlesource.com/chromium/src/+/6280ec5b6e3b4c307926eb1bf0167acc2a0d4a74 > Review-Url: https://codereview.chromium.org/2729523002 > Cr-Commit-Position: refs/heads/master@{#456130} > Committed: https://chromium.googlesource.com/chromium/src/+/9f86464794416e81abfe5921e9fac892716c610b TBR=mthiesse@chromium.org,bajones@chromium.org,khushalsagar@chromium.org,dcheng@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=698643 Review-Url: https://codereview.chromium.org/2742083002 Cr-Commit-Position: refs/heads/master@{#456164} Committed: https://chromium.googlesource.com/chromium/src/+/587f430144e9a2ad778649dff1c297b09977c2a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -1075 lines) Patch
M chrome/browser/android/vr_shell/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/android/vr_shell/mailbox_to_surface_bridge.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/android/vr_shell/mailbox_to_surface_bridge.cc View 1 chunk +0 lines, -345 lines 0 comments Download
M chrome/browser/android/vr_shell/non_presenting_gvr_delegate.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/non_presenting_gvr_delegate.cc View 6 chunks +8 lines, -31 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.h View 3 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell.cc View 10 chunks +7 lines, -57 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.h View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.cc View 5 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.h View 10 chunks +7 lines, -35 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.cc View 19 chunks +115 lines, -222 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_renderer.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M device/vr/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M device/vr/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M device/vr/android/gvr/gvr_delegate.h View 2 chunks +4 lines, -5 lines 0 comments Download
M device/vr/android/gvr/gvr_device.h View 1 chunk +3 lines, -7 lines 0 comments Download
M device/vr/android/gvr/gvr_device.cc View 4 chunks +8 lines, -14 lines 0 comments Download
M device/vr/android/gvr/gvr_device_provider.h View 2 chunks +2 lines, -7 lines 0 comments Download
M device/vr/android/gvr/gvr_device_provider.cc View 2 chunks +19 lines, -19 lines 0 comments Download
M device/vr/test/fake_vr_device.h View 1 chunk +3 lines, -7 lines 0 comments Download
M device/vr/test/fake_vr_device.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M device/vr/vr_device.h View 1 chunk +3 lines, -7 lines 0 comments Download
M device/vr/vr_device.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M device/vr/vr_display_impl.h View 1 chunk +2 lines, -6 lines 0 comments Download
M device/vr/vr_display_impl.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M device/vr/vr_display_impl_unittest.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M device/vr/vr_service.mojom View 2 chunks +4 lines, -12 lines 0 comments Download
M gpu/ipc/common/mailbox_holder.typemap View 1 chunk +0 lines, -4 lines 0 comments Download
D gpu/ipc/common/mailbox_holder_for_blink.typemap View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 5 chunks +6 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 16 chunks +163 lines, -134 lines 0 comments Download
M third_party/WebKit/public/blink_typemaps.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
klausw
Created Revert of Re-land WebVR compositor bypass via BrowserMain context + mailbox
3 years, 9 months ago (2017-03-10 20:46:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742083002/1
3 years, 9 months ago (2017-03-10 20:47:28 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-10 20:47:30 UTC) #5
ddorwin
lgtm
3 years, 9 months ago (2017-03-10 21:13:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742083002/1
3 years, 9 months ago (2017-03-10 21:14:23 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 21:16:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/587f430144e9a2ad778649dff1c2...

Powered by Google App Engine
This is Rietveld 408576698