Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2742063002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, pam+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file( pref, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=pam@chromium.org, bauerb@chromium.org Review-Url: https://codereview.chromium.org/2742063002 Cr-Commit-Position: refs/heads/master@{#460811} Committed: https://chromium.googlesource.com/chromium/src/+/ef7971d76c84db428886e1aaa3468fe3d957618b

Patch Set 1 : Add TEAM/COMPONENT #

Total comments: 2

Patch Set 2 : change UI>Browser>Preferences>Protector to UI>Browser>Preferences #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/prefs/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/prefs/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/pref_registry/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/prefs/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/supervised_user_error_page/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_preferences/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/user_prefs/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-10 19:21:32 UTC) #1
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-10 19:33:58 UTC) #4
ymzhang1
3 years, 9 months ago (2017-03-10 19:34:38 UTC) #6
Bernhard Bauer
Oh sorry, I missed this. LGTM with one change in several files: https://codereview.chromium.org/2742063002/diff/20001/chrome/browser/prefs/OWNERS File chrome/browser/prefs/OWNERS ...
3 years, 8 months ago (2017-03-30 17:09:41 UTC) #7
ymzhang1
https://codereview.chromium.org/2742063002/diff/20001/chrome/browser/prefs/OWNERS File chrome/browser/prefs/OWNERS (right): https://codereview.chromium.org/2742063002/diff/20001/chrome/browser/prefs/OWNERS#newcode6 chrome/browser/prefs/OWNERS:6: # COMPONENT: UI>Browser>Preferences>Protector On 2017/03/30 17:09:40, Bernhard Bauer wrote: ...
3 years, 8 months ago (2017-03-30 17:16:23 UTC) #8
ymzhang1
3 years, 8 months ago (2017-03-30 17:16:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742063002/40001
3 years, 8 months ago (2017-03-30 17:17:07 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 17:27:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ef7971d76c84db428886e1aaa346...

Powered by Google App Engine
This is Rietveld 408576698