Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Issue 2742033002: Update scheme text color in Omnibox only in non-default Security Levels (Closed)

Created:
3 years, 9 months ago by elawrence
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Update scheme text color in Omnibox only in non-default Security Levels A recent refactoring dropped a test from the conditional which caused the Omnibox to paint the scheme text in black in cases where it should not. Restore the conditional so that the Omnibox only colors the scheme text in the correct scenarios. BUG=699222 TEST=Type about:blank in the omnibox and hit enter. "about:" should be grey and "blank" should be black Review-Url: https://codereview.chromium.org/2734783007 Cr-Commit-Position: refs/heads/master@{#455783} (cherry picked from commit f079e7398cefd26400234c38a83630d2f5730969) Review-Url: https://codereview.chromium.org/2742033002 . Cr-Commit-Position: refs/branch-heads/3029@{#112} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/df154b0f0305d236a6d71a63a6a120bfe55b3bec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
elawrence
3 years, 9 months ago (2017-03-10 17:44:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
df154b0f0305d236a6d71a63a6a120bfe55b3bec.

Powered by Google App Engine
This is Rietveld 408576698