Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2742013003: Update baselines in editing/ for Mac10.12. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
eae, Xiaocheng
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, dcheng, eae, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update baselines in editing/ for Mac10.12. BUG=697971 Review-Url: https://codereview.chromium.org/2742013003 Cr-Commit-Position: refs/heads/master@{#456506} Committed: https://chromium.googlesource.com/chromium/src/+/468205e32ccb6cefa145f6aa4d10276f646d972d

Patch Set 1 #

Patch Set 2 : Rebaseline #

Patch Set 3 : Update to only rebaseline some tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -56 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 2 chunks +37 lines, -48 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/input/caret-at-the-edge-of-input-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/input/caret-at-the-edge-of-input-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/input/reveal-caret-of-multiline-input-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/pasteboard/drop-text-without-selection-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/pasteboard/pasting-tabs-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/replaced-boundaries-3-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/select-across-readonly-input-1-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/select-across-readonly-input-2-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/select-across-readonly-input-3-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/select-across-readonly-input-4-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/select-across-readonly-input-4-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/select-across-readonly-input-5-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/select-across-readonly-input-5-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/selection-button-text-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-mac10.11/editing/selection/selection-button-text-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/input/caret-at-the-edge-of-input-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/input/caret-at-the-edge-of-input-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/input/reveal-caret-of-multiline-input-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/pasteboard/drop-text-without-selection-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/pasteboard/pasting-tabs-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/selection/replaced-boundaries-3-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/selection/select-across-readonly-input-1-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/selection/select-across-readonly-input-2-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/selection/select-across-readonly-input-3-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/selection/select-across-readonly-input-4-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/selection/select-across-readonly-input-4-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/selection/select-across-readonly-input-5-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/selection/select-across-readonly-input-5-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/selection/selection-button-text-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/mac-retina/editing/selection/selection-button-text-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/input/caret-at-the-edge-of-input-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/input/reveal-caret-of-multiline-input-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/drop-text-without-selection-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/pasting-tabs-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/pasting-tabs-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/replaced-boundaries-3-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/replaced-boundaries-3-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-across-readonly-input-1-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-across-readonly-input-2-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-across-readonly-input-3-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-across-readonly-input-4-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-across-readonly-input-4-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-across-readonly-input-5-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-across-readonly-input-5-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/select-element-paragraph-boundary-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/selection-button-text-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/selection/selection-button-text-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
qyearsley
3 years, 9 months ago (2017-03-10 19:43:30 UTC) #2
Xiaocheng
Sorry for the long delay. I'm wonder why some characters are missing in the modified ...
3 years, 9 months ago (2017-03-11 03:21:35 UTC) #4
eae
LGTM
3 years, 9 months ago (2017-03-11 03:29:32 UTC) #6
qyearsley
On 2017/03/11 at 03:21:35, xiaochengh wrote: > Sorry for the long delay. > > I'm ...
3 years, 9 months ago (2017-03-11 23:57:37 UTC) #7
Xiaocheng
lgtm Yes, please file a bug
3 years, 9 months ago (2017-03-13 19:13:43 UTC) #8
qyearsley
On 2017/03/13 at 19:13:43, xiaochengh wrote: > lgtm > > Yes, please file a bug ...
3 years, 9 months ago (2017-03-13 20:38:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742013003/40001
3 years, 9 months ago (2017-03-13 20:39:07 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 22:14:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/468205e32ccb6cefa145f6aa4d10...

Powered by Google App Engine
This is Rietveld 408576698