Don't skip ARC ToS due to policies if ArcEnabled is not managed

Don't skip ARC ToS due to policies if ArcEnabled is not managed

This fixes unintentional change made in commit
13c620a0df3f13dfb9f43c92faf2b608e0c63215 that made the ARC Terms of
Service screen being skipped when only ArcBackupRestoreEnabled and
ArcLocationServiceEnabled are managed, while the ARC itself is not.
That was an incorrect change, because the user must consent with ARC
Terms when ArcEnabled is not set via policy.

This CL changes this back to the original behavior that was
introduced in commit f392d837d227d79a9b8dec1d298e9c562929c7cf, that is:

> Skip the ARC initial screen during provision when there is nothing
> to be requested from the user on that screen, i.e. when the following
> conditions are all true:
> 1. ArcEnabled policy is set to true;
> 2. ArcBackupRestoreEnabled policy is set to some value;
> 3. ArcLocationServiceEnabled policy is set to some value.

The unit tests are now extended to cover this piece of logic.

BUG=657687
BUG=b/31079732
TEST=new unit tests

Review-Url: https://codereview.chromium.org/2742013002
Cr-Commit-Position: refs/heads/master@{#456302}
Committed: https://chromium.googlesource.com/chromium/src/+/12fb4ebfdafb2660d75e85b8b4d233fd3cfe1507

[emaxx, 2017-03-10 16:50:05]

The CQ bit was checked by emaxx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 16:50:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emaxx, 2017-03-10 16:51:55]

emaxx@chromium.org changed reviewers:
+ hidehiko@chromium.org

[emaxx, 2017-03-10 16:51:55]

Hidehiko, PTAL.

[commit-bot: I haz the power, 2017-03-10 17:18:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 17:18:42]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2017-03-12 16:18:10]

lgtm

[emaxx, 2017-03-12 16:22:40]

The CQ bit was checked by emaxx@chromium.org

[commit-bot: I haz the power, 2017-03-12 16:22:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-12 16:55:51]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489335760349860, "parent_rev":
"b74643ed9b6adc24b73756ff340354f65306524c", "commit_rev":
"12fb4ebfdafb2660d75e85b8b4d233fd3cfe1507"}

[commit-bot: I haz the power, 2017-03-12 16:56:33]

Description was changed from

==========
Don't skip ARC ToS due to policies if ArcEnabled is not managed

This fixes unintentional change made in commit
13c620a0df3f13dfb9f43c92faf2b608e0c63215 that made the ARC Terms of
Service screen being skipped when only ArcBackupRestoreEnabled and
ArcLocationServiceEnabled are managed, while the ARC itself is not.
That was an incorrect change, because the user must consent with ARC
Terms when ArcEnabled is not set via policy.

This CL changes this back to the original behavior that was
introduced in commit f392d837d227d79a9b8dec1d298e9c562929c7cf, that is:

> Skip the ARC initial screen during provision when there is nothing
> to be requested from the user on that screen, i.e. when the following
> conditions are all true:
> 1. ArcEnabled policy is set to true;
> 2. ArcBackupRestoreEnabled policy is set to some value;
> 3. ArcLocationServiceEnabled policy is set to some value.

The unit tests are now extended to cover this piece of logic.

BUG=657687
BUG=b/31079732
TEST=new unit tests
==========

to

==========
Don't skip ARC ToS due to policies if ArcEnabled is not managed

This fixes unintentional change made in commit
13c620a0df3f13dfb9f43c92faf2b608e0c63215 that made the ARC Terms of
Service screen being skipped when only ArcBackupRestoreEnabled and
ArcLocationServiceEnabled are managed, while the ARC itself is not.
That was an incorrect change, because the user must consent with ARC
Terms when ArcEnabled is not set via policy.

This CL changes this back to the original behavior that was
introduced in commit f392d837d227d79a9b8dec1d298e9c562929c7cf, that is:

> Skip the ARC initial screen during provision when there is nothing
> to be requested from the user on that screen, i.e. when the following
> conditions are all true:
> 1. ArcEnabled policy is set to true;
> 2. ArcBackupRestoreEnabled policy is set to some value;
> 3. ArcLocationServiceEnabled policy is set to some value.

The unit tests are now extended to cover this piece of logic.

BUG=657687
BUG=b/31079732
TEST=new unit tests

Review-Url: https://codereview.chromium.org/2742013002
Cr-Commit-Position: refs/heads/master@{#456302}
Committed:
https://chromium.googlesource.com/chromium/src/+/12fb4ebfdafb2660d75e85b8b4d2...
==========

[commit-bot: I haz the power, 2017-03-12 16:56:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/12fb4ebfdafb2660d75e85b8b4d2...