Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 2741993003: Revert restartInput change off the M57 release branch. (Closed)

Created:
3 years, 9 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, dglazkov+blink, darin-cc_chromium.org, agrieve+watch_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert restartInput change off the M57 release branch. Although there are no known problems with this patch, this should minimize risk given that we are landing another fix for the root cause http://crrev.com/456116. Revert "[Android] Restart input only once on focus change" This reverts commit 9353655a861dd23ab239f5f400650bc04050ca2e. Revert "Fix Windows compile error with cherry-pick." This reverts commit ec5e87b1835fd460bc175897024a44f567b32e22. BUG=650204, 699699 Review-Url: https://codereview.chromium.org/2741993003 . Cr-Commit-Position: refs/branch-heads/2987@{#811} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/7026b266c93ccd4ad36cc3a543381ff6b8b78baf

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -91 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +4 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 6 chunks +39 lines, -35 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 2 chunks +7 lines, -37 lines 0 comments Download
M content/renderer/input/render_widget_input_handler_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_widget.h View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebViewClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebWidgetClient.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
aelias_OOO_until_Jul13
3 years, 9 months ago (2017-03-10 19:18:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7026b266c93ccd4ad36cc3a543381ff6b8b78baf.

Powered by Google App Engine
This is Rietveld 408576698