Chromium Code Reviews
Help | Chromium Project | Sign in
(5)

Issue 2741993002: Move common gradient attribute collection to SVGGradientElement (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 6 days ago by fs
Modified:
2 weeks, 3 days ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move common gradient attribute collection to SVGGradientElement Move the collection of attributes shared by both gradient types to the base class (collectCommonAttributes.) Introduce a new helper for looking up a potential element to inherit attributes from. Restructure the "collection loop" a bit after the common code has been broken out. This also means that buildStops() can be made private. BUG=661598 Review-Url: https://codereview.chromium.org/2741993002 Cr-Commit-Position: refs/heads/master@{#456371} Committed: https://chromium.googlesource.com/chromium/src/+/6729d1ecf49a910999920ee6102bc48821127607

Patch Set 1 #

Patch Set 2 : Fix casting #

Patch Set 3 : Rebase; fix semantics on find cycle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -128 lines) Patch
M third_party/WebKit/Source/core/svg/SVGGradientElement.h View 3 chunks +12 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGGradientElement.cpp View 1 2 chunks +32 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLinearGradientElement.cpp View 1 2 1 chunk +27 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRadialGradientElement.cpp View 1 2 1 chunk +29 lines, -61 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 21 (17 generated)
fs
2 weeks, 3 days ago (2017-03-13 12:46:24 UTC) #15
Stephen Chennney
lgtm
2 weeks, 3 days ago (2017-03-13 14:19:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741993002/40001
2 weeks, 3 days ago (2017-03-13 14:19:43 UTC) #18
commit-bot: I haz the power
2 weeks, 3 days ago (2017-03-13 14:24:12 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6729d1ecf49a910999920ee6102b...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46