Move common gradient attribute collection to SVGGradientElement

Move common gradient attribute collection to SVGGradientElement

Move the collection of attributes shared by both gradient types to the
base class (collectCommonAttributes.) Introduce a new helper for looking
up a potential element to inherit attributes from. Restructure the
"collection loop" a bit after the common code has been broken out.
This also means that buildStops() can be made private.

BUG=661598
Review-Url: https://codereview.chromium.org/2741993002
Cr-Commit-Position: refs/heads/master@{#456371}
Committed: https://chromium.googlesource.com/chromium/src/+/6729d1ecf49a910999920ee6102bc48821127607

[fs, 2017-03-10 15:18:01]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 15:18:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-03-10 15:20:12]

Description was changed from

==========
Move common gradient attribute collection to SVGGradientElement

Move the collection of attributes shared by both gradient types to the
base class (collectCommonAttributes.) Introduce a new helper for looking
up a potential element to inherit attributes from.
This also means that buildStops() can be made private.

BUG=661598
==========

to

==========
Move common gradient attribute collection to SVGGradientElement

Move the collection of attributes shared by both gradient types to the
base class (collectCommonAttributes.) Introduce a new helper for looking
up a potential element to inherit attributes from. Restructure the
"collection loop" a bit after the common code has been broken out.
This also means that buildStops() can be made private.

BUG=661598
==========

[commit-bot: I haz the power, 2017-03-10 15:41:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 15:41:27]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[fs, 2017-03-13 08:26:55]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 08:27:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 09:51:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 09:51:35]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fs, 2017-03-13 10:18:36]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 10:18:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 12:29:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 12:29:29]

Dry run: This issue passed the CQ dry run.

[fs, 2017-03-13 12:46:23]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[Stephen Chennney, 2017-03-13 14:19:26]

The CQ bit was checked by schenney@chromium.org

[Stephen Chennney, 2017-03-13 14:19:26]

lgtm

[commit-bot: I haz the power, 2017-03-13 14:19:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 14:23:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489414766104540,
"parent_rev": "f44c2a399aee72db9b7a54a30fde2964c5c32558", "commit_rev":
"6729d1ecf49a910999920ee6102bc48821127607"}

[commit-bot: I haz the power, 2017-03-13 14:24:11]

Description was changed from

==========
Move common gradient attribute collection to SVGGradientElement

Move the collection of attributes shared by both gradient types to the
base class (collectCommonAttributes.) Introduce a new helper for looking
up a potential element to inherit attributes from. Restructure the
"collection loop" a bit after the common code has been broken out.
This also means that buildStops() can be made private.

BUG=661598
==========

to

==========
Move common gradient attribute collection to SVGGradientElement

Move the collection of attributes shared by both gradient types to the
base class (collectCommonAttributes.) Introduce a new helper for looking
up a potential element to inherit attributes from. Restructure the
"collection loop" a bit after the common code has been broken out.
This also means that buildStops() can be made private.

BUG=661598

Review-Url: https://codereview.chromium.org/2741993002
Cr-Commit-Position: refs/heads/master@{#456371}
Committed:
https://chromium.googlesource.com/chromium/src/+/6729d1ecf49a910999920ee6102b...
==========

[commit-bot: I haz the power, 2017-03-13 14:24:12]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6729d1ecf49a910999920ee6102b...