Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 2741993002: Move common gradient attribute collection to SVGGradientElement (Closed)

Created:
8 months, 2 weeks ago by fs
Modified:
8 months, 2 weeks ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, fmalita+watch_chromium.org, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move common gradient attribute collection to SVGGradientElement Move the collection of attributes shared by both gradient types to the base class (collectCommonAttributes.) Introduce a new helper for looking up a potential element to inherit attributes from. Restructure the "collection loop" a bit after the common code has been broken out. This also means that buildStops() can be made private. BUG=661598 Review-Url: https://codereview.chromium.org/2741993002 Cr-Commit-Position: refs/heads/master@{#456371} Committed: https://chromium.googlesource.com/chromium/src/+/6729d1ecf49a910999920ee6102bc48821127607

Patch Set 1 #

Patch Set 2 : Fix casting #

Patch Set 3 : Rebase; fix semantics on find cycle #

Messages

Total messages: 21 (17 generated)
fs
8 months, 2 weeks ago (2017-03-13 12:46:24 UTC) #15
Stephen Chennney
lgtm
8 months, 2 weeks ago (2017-03-13 14:19:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741993002/40001
8 months, 2 weeks ago (2017-03-13 14:19:43 UTC) #18
commit-bot: I haz the power
8 months, 2 weeks ago (2017-03-13 14:24:12 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6729d1ecf49a910999920ee6102b...

Powered by Google App Engine
This is Rietveld efc10ee0f