Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2741953003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
msarda
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, ios-reviews_chromium.org, tengs+watch-tether_chromium.org, pkl (ping after 24h if needed), hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, khorimoto+watch-tether_chromium.org, sync-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file( signin, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=msarda@chromium.org Review-Url: https://codereview.chromium.org/2741953003 Cr-Commit-Position: refs/heads/master@{#456899} Committed: https://chromium.googlesource.com/chromium/src/+/9683d88a4b2ae5652c5ea6d9e5117bf9ad628824

Patch Set 1 : Add TEAM/COMPONENT #

Total comments: 4

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/ui/sync/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/signin/ios/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/gaia/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/first_run/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/signin/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/authentication/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/sync/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/signin/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-10 19:54:48 UTC) #2
msarda
LGTM with some nits. https://codereview.chromium.org/2741953003/diff/20001/google_apis/gaia/OWNERS File google_apis/gaia/OWNERS (right): https://codereview.chromium.org/2741953003/diff/20001/google_apis/gaia/OWNERS#newcode5 google_apis/gaia/OWNERS:5: # COMPONENT: Internals "Services>SignIn" as ...
3 years, 9 months ago (2017-03-14 13:53:21 UTC) #3
ymzhang1
Thanks for the comments! https://codereview.chromium.org/2741953003/diff/20001/google_apis/gaia/OWNERS File google_apis/gaia/OWNERS (right): https://codereview.chromium.org/2741953003/diff/20001/google_apis/gaia/OWNERS#newcode5 google_apis/gaia/OWNERS:5: # COMPONENT: Internals On 2017/03/14 ...
3 years, 9 months ago (2017-03-14 23:42:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741953003/40001
3 years, 9 months ago (2017-03-14 23:43:39 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 23:57:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9683d88a4b2ae5652c5ea6d9e511...

Powered by Google App Engine
This is Rietveld 408576698