Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2741933004: [Blink, Media] Added controlsList to HTMLMediaElement (Closed)

Created:
3 years, 9 months ago by whywhat
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Blink, Media] Added controlsList to HTMLMediaElement Adds a DOMTokenList backed controlsList/controlslist attribute to HTMLMediaElement with three keywords: nodownload, nofullscreen and noremoteplayback. Spec change is discussed here: https://github.com/whatwg/html/issues/2293 Spec change PR is here: https://github.com/whatwg/html/pull/2426 WICG repo for the API is here: https://github.com/WICG/controls-list Intent to ship is here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tFuQd3AcsIQ/discussion BUG=650174, 685018 TEST=manual+layout tests Review-Url: https://codereview.chromium.org/2657723002 Cr-Commit-Position: refs/heads/master@{#455926} (cherry picked from commit caca06866f37c79df89cab9a634bb7497177236e) Review-Url: https://codereview.chromium.org/2741933004 . Cr-Commit-Position: refs/branch-heads/3029@{#132} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/1f92e23e416a507c94523e120d1d4608b4ef087f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/media/controls/controls-list-add-hide.html View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/media/controls/controls-list-remove-show.html View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-controls.js View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.json5 View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 5 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 4 chunks +24 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/html/HTMLMediaElementControlsList.h View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/html/HTMLMediaElementControlsList.cpp View 1 chunk +60 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 4 chunks +20 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
whywhat
3 years, 9 months ago (2017-03-11 14:27:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1f92e23e416a507c94523e120d1d4608b4ef087f (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698