Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 274193005: ozone: Allow loading the platform implementation from a system library. (Closed)

Created:
6 years, 7 months ago by sadrul
Modified:
4 years, 1 month ago
Reviewers:
rjkroege, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Visibility:
Public.

Description

ozone: Allow loading the platform implementation from a system library. The X11 implementation for the ozone platform is built as a separate library. Chrome will use this platform only if it is available at runtime. This allows building and testing ozone on the desktop with the X11 implementation, but deploy the same build on the device without the X11 implementation and have it running using a more appropriate platform implementation. BUG=361137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/ozone_platform.cc View 2 chunks +32 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sadrul
[ the master CL is: https://codereview.chromium.org/275263002/ ]
6 years, 7 months ago (2014-05-09 23:19:02 UTC) #1
spang
I made a similar attempt to support modular platforms. Everything works perfectly until you do ...
6 years, 7 months ago (2014-05-10 02:09:27 UTC) #2
sadrul
On 2014/05/10 02:09:27, spang wrote: > I made a similar attempt to support modular platforms. ...
6 years, 7 months ago (2014-05-12 01:15:44 UTC) #3
rjkroege
On 2014/05/12 01:15:44, sadrul wrote: > On 2014/05/10 02:09:27, spang wrote: > > I made ...
6 years, 7 months ago (2014-05-12 12:39:30 UTC) #4
spang
On 2014/05/12 01:15:44, sadrul wrote: > On 2014/05/10 02:09:27, spang wrote: > > I made ...
6 years, 7 months ago (2014-05-12 14:50:58 UTC) #5
sadrul
On 2014/05/12 14:50:58, spang wrote: > What refactoring do you have in mind? The symbol ...
6 years, 7 months ago (2014-05-12 22:01:58 UTC) #6
spang
6 years, 7 months ago (2014-05-12 22:09:34 UTC) #7
On 2014/05/12 22:01:58, sadrul wrote:
> On 2014/05/12 14:50:58, spang wrote:
> > What refactoring do you have in mind? The symbol hiding is by design and
also
> > makes chrome load faster. I'm not sure it's worth pursuing exposing gfx,
> events,
> > & skia to libraries, because I imagine it will be viewed as a step backwards
> by
> > the team.
> 
> On 2014/05/12 12:39:30, rjkroege wrote:
> > sadrul@: I thought you'd indicated to me that the X11 ozone platform would
> > always get built as a separate .so target which was intended to resolve this
> > issue?
> 
> Yep. That's what I have in mind. I am able to build a libozonex.so and load it
> from a static_library build after sufficient amount of persuasion (and without
> events support for now), without having to build .sos for gfx, events etc. So
I
> am still hopeful that it should be possible to do this.

I would like to understand the persuasion before landing this.

Powered by Google App Engine
This is Rietveld 408576698