Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: PRESUBMIT.py

Issue 274193005: ozone: Allow loading the platform implementation from a system library. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ui/ozone/ozone_platform.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 ( 162 (
163 'New code should not use ScopedAllowIO. Post a task to the blocking', 163 'New code should not use ScopedAllowIO. Post a task to the blocking',
164 'pool or the FILE thread instead.', 164 'pool or the FILE thread instead.',
165 ), 165 ),
166 True, 166 True,
167 ( 167 (
168 r"^components[\\\/]breakpad[\\\/]app[\\\/]breakpad_mac\.mm$", 168 r"^components[\\\/]breakpad[\\\/]app[\\\/]breakpad_mac\.mm$",
169 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", 169 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",
170 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", 170 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",
171 r"^mojo[\\\/]system[\\\/]raw_shared_buffer_posix\.cc$", 171 r"^mojo[\\\/]system[\\\/]raw_shared_buffer_posix\.cc$",
172 r"^ui[\\\/]ozone[\\\/]ozone_platform\.cc$",
172 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", 173 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$",
173 ), 174 ),
174 ), 175 ),
175 ( 176 (
176 'SkRefPtr', 177 'SkRefPtr',
177 ( 178 (
178 'The use of SkRefPtr is prohibited. ', 179 'The use of SkRefPtr is prohibited. ',
179 'Please use skia::RefPtr instead.' 180 'Please use skia::RefPtr instead.'
180 ), 181 ),
181 True, 182 True,
(...skipping 1358 matching lines...) Expand 10 before | Expand all | Expand 10 after
1540 builders.extend(['cros_x86']) 1541 builders.extend(['cros_x86'])
1541 1542
1542 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it 1543 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
1543 # unless they're .gyp(i) files as changes to those files can break the gyp 1544 # unless they're .gyp(i) files as changes to those files can break the gyp
1544 # step on that bot. 1545 # step on that bot.
1545 if (not all(re.search('^chrome', f) for f in files) or 1546 if (not all(re.search('^chrome', f) for f in files) or
1546 any(re.search('\.gypi?$', f) for f in files)): 1547 any(re.search('\.gypi?$', f) for f in files)):
1547 builders.extend(['android_aosp']) 1548 builders.extend(['android_aosp'])
1548 1549
1549 return GetDefaultTryConfigs(builders) 1550 return GetDefaultTryConfigs(builders)
OLDNEW
« no previous file with comments | « no previous file | ui/ozone/ozone_platform.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698