|
|
DescriptionOrdered outputs of css_properties in core/BUILD.gn alphabetically.
Ordered the generated files in the outputs parameter of the
css_properties target of core/BUILD.gn alphabetically.
This makes the file more readable and makes it simpler to add a new
file to the list while avoiding merge conflicts.
BUG=668012
Review-Url: https://codereview.chromium.org/2741913002
Cr-Commit-Position: refs/heads/master@{#456544}
Committed: https://chromium.googlesource.com/chromium/src/+/0b8c6786e4cd01e31ce7d141bfdfb934ec0d886a
Patch Set 1 #Patch Set 2 : Rebased #Messages
Total messages: 20 (14 generated)
The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run
bugsnash@chromium.org changed reviewers: + rvera@chromium.org
bugsnash@chromium.org changed reviewers: + shend@chromium.org - rvera@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm. Ideally, we wouldn't need to specify those files explicitly, but apparently it requires some dark gn/ninja magic. Something worth looking into though.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bugsnash@chromium.org changed reviewers: + meade@chromium.org
meade@ for owners
lgtm \o/
The CQ bit was checked by bugsnash@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489442142236150, "parent_rev": "b9414864f5480e5f83d24ecb949e60834e388a79", "commit_rev": "0b8c6786e4cd01e31ce7d141bfdfb934ec0d886a"}
Message was sent while issue was closed.
Description was changed from ========== Ordered outputs of css_properties in core/BUILD.gn alphabetically. Ordered the generated files in the outputs parameter of the css_properties target of core/BUILD.gn alphabetically. This makes the file more readable and makes it simpler to add a new file to the list while avoiding merge conflicts. BUG=668012 ========== to ========== Ordered outputs of css_properties in core/BUILD.gn alphabetically. Ordered the generated files in the outputs parameter of the css_properties target of core/BUILD.gn alphabetically. This makes the file more readable and makes it simpler to add a new file to the list while avoiding merge conflicts. BUG=668012 Review-Url: https://codereview.chromium.org/2741913002 Cr-Commit-Position: refs/heads/master@{#456544} Committed: https://chromium.googlesource.com/chromium/src/+/0b8c6786e4cd01e31ce7d141bfdf... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0b8c6786e4cd01e31ce7d141bfdf... |