Fix ScrollAnchor descent into absolute-positioned containers.

Fix ScrollAnchor descent into absolute-positioned containers.

If the normal DOM walk yields nothing, examine the positioned descendants that
were skipped due to their DOM parents being offscreen.

BUG=692701
Review-Url: https://codereview.chromium.org/2741853006
Cr-Commit-Position: refs/heads/master@{#456575}
Committed: https://chromium.googlesource.com/chromium/src/+/eeb280562292e14bdfc3dfa494f6599a1d43ae2b

[skobes, 2017-03-11 00:49:37]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 00:50:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2017-03-11 00:50:29]

skobes@chromium.org changed reviewers:
+ atotic@chromium.org

[commit-bot: I haz the power, 2017-03-11 02:33:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 02:33:52]

Dry run: This issue passed the CQ dry run.

[atotic, 2017-03-13 20:17:21]

On 2017/03/11 at 00:50:30, skobes wrote:
> 

lgtm

FYI:

findAnchorRecursive(LayoutObject*) was messing with me. My brain kept insisting
that findAnchorRecursive returns true when something was found. In fact,
it returns true when not found (ie, continue searching).

[skobes, 2017-03-13 22:27:43]

On 2017/03/13 20:17:21, atotic wrote:
> findAnchorRecursive(LayoutObject*) was messing with me. My brain kept
insisting
> that findAnchorRecursive returns true when something was found. In fact,
> it returns true when not found (ie, continue searching).

You're right, it's better the other way around.  Fixed.

[skobes, 2017-03-13 22:28:03]

The CQ bit was checked by skobes@chromium.org

[skobes, 2017-03-13 22:28:03]

The patchset sent to the CQ was uploaded after l-g-t-m from atotic@chromium.org
Link to the patchset: https://codereview.chromium.org/2741853006/#ps20001
(title: "invert return value")

[commit-bot: I haz the power, 2017-03-13 22:28:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 22:28:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 22:28:47]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[skobes, 2017-03-13 22:35:20]

skobes@chromium.org changed reviewers:
+ szager@chromium.org

[skobes, 2017-03-13 23:00:22]

The CQ bit was checked by skobes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 23:01:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[szager1, 2017-03-14 00:13:27]

lgtm

[commit-bot: I haz the power, 2017-03-14 00:36:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 00:36:55]

Dry run: This issue passed the CQ dry run.

[skobes, 2017-03-14 01:04:19]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2017-03-14 01:04:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 02:14:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489453459023470,
"parent_rev": "e822cb48dfbb15148b619d83e4107cc159c46aaf", "commit_rev":
"eeb280562292e14bdfc3dfa494f6599a1d43ae2b"}

[commit-bot: I haz the power, 2017-03-14 02:15:10]

Description was changed from

==========
Fix ScrollAnchor descent into absolute-positioned containers.

If the normal DOM walk yields nothing, examine the positioned descendants that
were skipped due to their DOM parents being offscreen.

BUG=692701
==========

to

==========
Fix ScrollAnchor descent into absolute-positioned containers.

If the normal DOM walk yields nothing, examine the positioned descendants that
were skipped due to their DOM parents being offscreen.

BUG=692701

Review-Url: https://codereview.chromium.org/2741853006
Cr-Commit-Position: refs/heads/master@{#456575}
Committed:
https://chromium.googlesource.com/chromium/src/+/eeb280562292e14bdfc3dfa494f6...
==========

[commit-bot: I haz the power, 2017-03-14 02:15:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eeb280562292e14bdfc3dfa494f6...