Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2741853006: Fix ScrollAnchor descent into absolute-positioned containers. (Closed)

Created:
3 years, 9 months ago by skobes
Modified:
3 years, 9 months ago
Reviewers:
atotic, szager1
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, ojan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ScrollAnchor descent into absolute-positioned containers. If the normal DOM walk yields nothing, examine the positioned descendants that were skipped due to their DOM parents being offscreen. BUG=692701 Review-Url: https://codereview.chromium.org/2741853006 Cr-Commit-Position: refs/heads/master@{#456575} Committed: https://chromium.googlesource.com/chromium/src/+/eeb280562292e14bdfc3dfa494f6599a1d43ae2b

Patch Set 1 #

Patch Set 2 : invert return value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -20 lines) Patch
M third_party/WebKit/Source/core/layout/ScrollAnchor.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchor.cpp View 1 2 chunks +41 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
skobes
3 years, 9 months ago (2017-03-11 00:50:30 UTC) #4
atotic
On 2017/03/11 at 00:50:30, skobes wrote: > lgtm FYI: findAnchorRecursive(LayoutObject*) was messing with me. My ...
3 years, 9 months ago (2017-03-13 20:17:21 UTC) #7
skobes
On 2017/03/13 20:17:21, atotic wrote: > findAnchorRecursive(LayoutObject*) was messing with me. My brain kept insisting ...
3 years, 9 months ago (2017-03-13 22:27:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741853006/20001
3 years, 9 months ago (2017-03-13 22:28:45 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-13 22:28:47 UTC) #13
skobes
3 years, 9 months ago (2017-03-13 22:35:20 UTC) #15
szager1
lgtm
3 years, 9 months ago (2017-03-14 00:13:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741853006/20001
3 years, 9 months ago (2017-03-14 01:04:55 UTC) #22
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 02:15:11 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eeb280562292e14bdfc3dfa494f6...

Powered by Google App Engine
This is Rietveld 408576698