Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 2741843003: [Home] Add more null checks for LayoutManagerChrome (Closed)

Created:
3 years, 9 months ago by Theresa
Modified:
3 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Add more null checks for LayoutManagerChrome The LayoutManagerChrome can still be null when #onNewTabPageShown() is called for the first time. BUG=699935 Review-Url: https://codereview.chromium.org/2741843003 Cr-Commit-Position: refs/heads/master@{#456137} Committed: https://chromium.googlesource.com/chromium/src/+/cc3b684f89c787d632a25c6037edbc5ba71c7da6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/ChromeHomeNewTabPage.java View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Theresa
ptal
3 years, 9 months ago (2017-03-10 19:14:26 UTC) #3
Ted C
lgtm
3 years, 9 months ago (2017-03-10 19:15:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741843003/1
3 years, 9 months ago (2017-03-10 19:15:51 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 19:50:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc3b684f89c787d632a25c6037ed...

Powered by Google App Engine
This is Rietveld 408576698