Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2741833003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 9 months ago
Reviewers:
estark
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (security, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=estark@chromium.org Review-Url: https://codereview.chromium.org/2741833003 Cr-Commit-Position: refs/heads/master@{#456145} Committed: https://chromium.googlesource.com/chromium/src/+/0903fb3cab79b6109da0ac0a0c743fd0ab6d0145

Patch Set 1 #

Patch Set 2 : add empty line #

Total comments: 4

Patch Set 3 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M chrome/browser/interstitials/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/certificate_reporting/OWNERS View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M components/security_interstitials/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/security_state/OWNERS View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M ios/chrome/browser/ssl/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-10 01:17:44 UTC) #1
estark
lgtm with a couple suggestions https://codereview.chromium.org/2741833003/diff/20001/components/certificate_reporting/OWNERS File components/certificate_reporting/OWNERS (right): https://codereview.chromium.org/2741833003/diff/20001/components/certificate_reporting/OWNERS#newcode6 components/certificate_reporting/OWNERS:6: # COMPONENT: Security>UX Suggest ...
3 years, 9 months ago (2017-03-10 19:53:28 UTC) #2
ymzhang1
https://codereview.chromium.org/2741833003/diff/20001/components/certificate_reporting/OWNERS File components/certificate_reporting/OWNERS (right): https://codereview.chromium.org/2741833003/diff/20001/components/certificate_reporting/OWNERS#newcode6 components/certificate_reporting/OWNERS:6: # COMPONENT: Security>UX On 2017/03/10 19:53:28, estark wrote: > ...
3 years, 9 months ago (2017-03-10 19:58:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741833003/40001
3 years, 9 months ago (2017-03-10 19:58:12 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 20:10:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0903fb3cab79b6109da0ac0a0c74...

Powered by Google App Engine
This is Rietveld 408576698