Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 274183002: Make it possible to build cronet without icu. (Closed)

Created:
6 years, 7 months ago by mmenke
Modified:
6 years, 7 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Make it possible to build cronet without icu. BUG=362608 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269687

Patch Set 1 #

Patch Set 2 : Remove gn files, add missing file #

Patch Set 3 : Trim headers, update gyp #

Patch Set 4 : Fix tests #

Patch Set 5 : Fix another test #

Patch Set 6 : Merge #

Patch Set 7 : Oops...add back file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -1962 lines) Patch
M components/cronet.gypi View 1 chunk +11 lines, -1 line 0 comments Download
M components/cronet/android/cronet_jni.cc View 2 chunks +6 lines, -1 line 0 comments Download
M net/android/net_jni_registrar.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + net/base/net_util_icu_unittest.cc View 1 2 6 10 chunks +3 lines, -830 lines 0 comments Download
M net/base/net_util_unittest.cc View 1 2 7 chunks +1 line, -1051 lines 0 comments Download
M net/net.gyp View 1 2 4 chunks +25 lines, -1 line 0 comments Download
M net/net.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 2 3 4 3 chunks +4 lines, -0 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 5 chunks +80 lines, -76 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mmenke
cronet seems to be compiling and working fine without icu. Bots are red because this ...
6 years, 7 months ago (2014-05-09 19:04:36 UTC) #1
mef
lgtm
6 years, 7 months ago (2014-05-09 19:16:20 UTC) #2
mmenke
On 2014/05/09 19:16:20, mef wrote: > lgtm Found a pair of bugs with net_unittests in ...
6 years, 7 months ago (2014-05-09 20:20:50 UTC) #3
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 7 months ago (2014-05-10 20:49:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/274183002/110001
6 years, 7 months ago (2014-05-10 20:49:48 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 01:49:58 UTC) #6
Message was sent while issue was closed.
Change committed as 269687

Powered by Google App Engine
This is Rietveld 408576698